Upgrade .NET from v8 to v10#57
Merged
Merged
Conversation
This way the root dir of the repo is less poluted.
knocte
force-pushed
the
wip/srcMoveAndDotnet10
branch
2 times, most recently
from
d7d28f4 to
4441d49
Compare
Even though we don't depend on Newtonsoft.Json directly, I guess transitive deps were: ``` Running unit tests... dotnet test /home/runner/work/fsx/fsx/src/Fsdk.Tests/Fsdk.Tests.fsproj Determining projects to restore... /home/runner/work/fsx/fsx/src/Fsdk.Tests/Fsdk.Tests.fsproj : error NU1903: Warning As Error: Package 'Newtonsoft.Json' 9.0.1 has a known high severity vulnerability, GHSA-5crp-9r3c-p9vr Restored /home/runner/work/fsx/fsx/src/Fsdk/Fsdk.fsproj (in 229 ms). Failed to restore /home/runner/work/fsx/fsx/src/Fsdk.Tests/Fsdk.Tests.fsproj (in 229 ms). Error when running 'dotnet test /home/runner/work/fsx/fsx/src/Fsdk.Tests/Fsdk.Tests.fsproj' FSI_0003.Fsdk.Process+ProcessFailed: ProcessFailed "Error when running 'dotnet test /home/runner/work/fsx/fsx/src/Fsdk.Tests/Fsdk.Tests.fsproj'" at FSI_0003.Fsdk.Process.ProcessResult.Unwrap(String errMsg) in /home/runner/work/fsx/fsx/src/Fsdk/Process.fs:line 139 at FSI_0003.Fsdk.Process.ProcessResult.UnwrapDefault() in /home/runner/work/fsx/fsx/src/Fsdk/Process.fs:line 151 at FSI_0006.RunUnitTests() in /home/runner/work/fsx/fsx/scripts/runUnitTests.fsx:line 135 at <StartupCode$FSI_0006>.$FSI_0006.main@() in /home/runner/work/fsx/fsx/scripts/runUnitTests.fsx:line 140 at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args) at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr) Stopped due to error Error: Process completed with exit code 1. ```
Otherwise we get warnings as errors that are kinda impossible to fix today: ``` /home/runner/work/fsx/fsx/src/Fsdk/Network.fs(246,9): error FS0044: This construct is deprecated. WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. Settings on ServicePointManager no longer affect SslStream or HttpClient. [/home/runner/work/fsx/fsx/src/fsx/fsx.fsproj] ```
I can't be bothered to fix them. If we need them in the future then I will create stable branches or whatever.
knocte
force-pushed
the
wip/srcMoveAndDotnet10
branch
from
cca5c71 to
4afc6e0
Compare
knocte
added a commit
that referenced
this pull request
May 19, 2026
* Move F# projects to src/ subdir This way the root dir of the repo is less poluted. * Upgrade .NET from v8 to v10 * Fsdk.Tests: upgrade deps to fix build Even though we don't depend on Newtonsoft.Json directly, I guess transitive deps were: ``` Running unit tests... dotnet test /home/runner/work/fsx/fsx/src/Fsdk.Tests/Fsdk.Tests.fsproj Determining projects to restore... /home/runner/work/fsx/fsx/src/Fsdk.Tests/Fsdk.Tests.fsproj : error NU1903: Warning As Error: Package 'Newtonsoft.Json' 9.0.1 has a known high severity vulnerability, GHSA-5crp-9r3c-p9vr Restored /home/runner/work/fsx/fsx/src/Fsdk/Fsdk.fsproj (in 229 ms). Failed to restore /home/runner/work/fsx/fsx/src/Fsdk.Tests/Fsdk.Tests.fsproj (in 229 ms). Error when running 'dotnet test /home/runner/work/fsx/fsx/src/Fsdk.Tests/Fsdk.Tests.fsproj' FSI_0003.Fsdk.Process+ProcessFailed: ProcessFailed "Error when running 'dotnet test /home/runner/work/fsx/fsx/src/Fsdk.Tests/Fsdk.Tests.fsproj'" at FSI_0003.Fsdk.Process.ProcessResult.Unwrap(String errMsg) in /home/runner/work/fsx/fsx/src/Fsdk/Process.fs:line 139 at FSI_0003.Fsdk.Process.ProcessResult.UnwrapDefault() in /home/runner/work/fsx/fsx/src/Fsdk/Process.fs:line 151 at FSI_0006.RunUnitTests() in /home/runner/work/fsx/fsx/scripts/runUnitTests.fsx:line 135 at <StartupCode$FSI_0006>.$FSI_0006.main@() in /home/runner/work/fsx/fsx/scripts/runUnitTests.fsx:line 140 at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args) at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr) Stopped due to error Error: Process completed with exit code 1. ``` * One more LEGACY_FRAMEWORK wrapping to fix build Otherwise we get warnings as errors that are kinda impossible to fix today: ``` /home/runner/work/fsx/fsx/src/Fsdk/Network.fs(246,9): error FS0044: This construct is deprecated. WebRequest, HttpWebRequest, ServicePoint, and WebClient are obsolete. Use HttpClient instead. Settings on ServicePointManager no longer affect SslStream or HttpClient. [/home/runner/work/fsx/fsx/src/fsx/fsx.fsproj] ``` * CI: remove old lanes I can't be bothered to fix them. If we need them in the future then I will create stable branches or whatever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And move all F# projs to a src/ subdir.