BREAKING: rename isInstanceOf(x,y) to cast(x).to(y)#13
Open
knocte wants to merge 5 commits into
Open
Conversation
It is way more readable, because this way you don't have to check which param is the type.
Most of the time when you're checking if a var is of type T, you want to cast afterwards if the result is true, so let's reuse Option types here. If you don't want to cast, you simply use isSome() or isNone() later.
Sounds better and shorter.
One of the last commits left this shit: ``` expect(Dyn.cast(foo).to<Foo>().isSome()).toBe(true); expect(Dyn.cast(bar).to<Bar>().isSome()).toBe(true); expect(Dyn.cast(foo).to<Bar>().isSome()).toBe(true); expect(Dyn.cast(bar).to<Foo>().isSome()).toBe(true); ```
Contributor
Author
|
TODO:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is way more readable, because this way you don't have to check which param is the type.