Repository navigation
fix: file dragged cards into pinboard tabs again - #17
Merged
Merged
Conversation
Dragging a card onto a pinboard tab did nothing: the card slid back with no highlight. The shelf's SwiftUI .onDrop installs a full-size drop view registered for public.item, so it claimed every drag over the shelf, and since the tab reordering change its delegate rejected card drags. The shelf now has no SwiftUI .onDrop. ShelfHostingView, the shelf's NSHostingView, is the only drag destination and handles both drags in AppKit: cards are filed into the tab under the pointer (which then opens), and tabs are reordered. Both resolve the tab from the frames the tabs publish. Dragging a card that isn't selected now selects it first, as in Finder. While a card drag is over a tab, a small callout hangs from that tab naming the board it will land in, follows the drag along the row, and confirms the drop for a moment afterwards. It replaces the "Added to" HUD; a failed drop still shows the HUD. Signed-off-by: devansh nigam <devanshn02@gmail.com>
Contributor
Author
NigamDevansh
marked this pull request as ready for review
October 1, 2026 12:27
Owner
|
Great job! This is a great addition. Thanks for the PR :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Fixes dragging a card onto a pinboard tab, which stopped working after #10 (tab reordering): the card just slid back.
.onDropanymore.ShelfHostingView(the shelf'sNSHostingView) handles both drags in AppKit: cards are filed into the tab under the pointer, and tabs are reordered as before.How you tested it
Screen.Recording.2026-10-01.at.5.44.54.PM.1.mp4
Built and ran on macOS 27:
git commit -s, or turn on the hook once withgit config core.hooksPath .githooks). The DCO check enforces this. SeeCONTRIBUTING.md.
swift test --package-path CopyCore): no engine changesCopyCore/Package.resolvedstill pins GRDB, KeyboardShortcuts and Sparkle: not touched