Repository navigation
Bugfix/color picker bugfix - #16
Merged
Merged
Conversation
Signed-off-by: devansh nigam <devanshn02@gmail.com>
Signed-off-by: devansh nigam <devanshn02@gmail.com>
Contributor
Author
Owner
|
That's awesome. Thanks for contributing!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two small shelf fixes:
also closed when the pinboard editor or the Adjust Color sheet closes, instead of staying on screen disconnected.
Video:
bug2.mp4
Video:
Screen.Recording.2026-09-28.at.1.12.06.AM.mov
How you tested it
Built and ran the app locally (Debug) and clicked through:
Color picker (macOS 26+)
Colors window closing
Search hint
Screen.Recording.2026-09-28.at.1.39.42.AM-1.mp4
Screen.Recording.2026-09-28.at.1.40.38.AM.mp4
No CopyCore (engine) changes, so no new tests; the changes are app-layer SwiftUI/AppKit UI behaviour.
git commit -s, or turn on the hook once withgit config core.hooksPath .githooks). The DCO check enforces this. SeeCONTRIBUTING.md.
swift test --package-path CopyCore) — N/A, no engine changesCopyCore/Package.resolvedstill pins GRDB, KeyboardShortcuts and Sparkle — untouched by this PR