Skip to content

Bugfix/color picker bugfix - #16

Merged
tarikbc merged 2 commits into
tarikbc:mainfrom
NigamDevansh:bugfix/color-picker-bugfix
Sep 27, 2026
Merged

tarikbc merged 2 commits into
tarikbc:mainfrom
NigamDevansh:bugfix/color-picker-bugfix

Conversation

@NigamDevansh

Copy link
Copy Markdown
Contributor

What this changes

Two small shelf fixes:

  1. Pinboard color picker – On macOS 26+ the system color well became a wide pill that overflowed its 22pt slot and covered the Graphite preset dot (and swallowed its clicks). On macOS 26+ the custom-color picker now sits beside the "Color" label, so all presets are visible and clickable; older macOS keeps the existing layout. The shared Colors window is
    also closed when the pinboard editor or the Adjust Color sheet closes, instead of staying on screen disconnected.
    Video:
bug2.mp4
  1. Search hint panel – The hint panel under the empty search field could not be dismissed without typing. Clicking anywhere in the shelf outside the search field (a card, a tab, empty space) now ends search editing and hides the hint. Clicks inside the field, or when the field has text, are unaffected. Esc behaves as before.

Video:

Screen.Recording.2026-09-28.at.1.12.06.AM.mov

How you tested it

Built and ran the app locally (Debug) and clicked through:

Color picker (macOS 26+)

  1. Open the shelf → edit a pinboard (pinboard editor popover).
  2. Before: the custom color pill overlaps the Graphite dot and clicking Graphite opens the color picker. After: the picker sits next to "Color"/"Custom" and every preset dot is selectable.
  3. Pick a custom color → the "Custom" label highlights; pick a preset → it switches back.

Colors window closing

  1. In the pinboard editor, click the custom color well so the system Colors window opens.
  2. Close the editor (click away / Esc). Before: the Colors window stays open. After: it closes.
  3. Repeat from Adjust Color on a card → same result.

Search hint

  1. Open the shelf and click into the empty search field → the hint panel appears.
  2. Click a card, a pinboard tab, or empty shelf space. Before: the hint stays. After: it hides and the click still acts on what was clicked.
  3. Click inside the search field again → hint stays. Type something, then click a card → the field keeps its text/focus.
  4. Press Esc while searching → same behaviour as before this change.
Screen.Recording.2026-09-28.at.1.39.42.AM-1.mp4
Screen.Recording.2026-09-28.at.1.40.38.AM.mp4

No CopyCore (engine) changes, so no new tests; the changes are app-layer SwiftUI/AppKit UI behaviour.


  • Every commit is signed off (git commit -s, or turn on the hook once with
    git config core.hooksPath .githooks). The DCO check enforces this. See
    CONTRIBUTING.md.
  • Engine changes come with tests (swift test --package-path CopyCore) — N/A, no engine changes
  • CopyCore/Package.resolved still pins GRDB, KeyboardShortcuts and Sparkle — untouched by this PR

Signed-off-by: devansh nigam <devanshn02@gmail.com>
Signed-off-by: devansh nigam <devanshn02@gmail.com>
@NigamDevansh

NigamDevansh commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor Author

Hi @tarikbc, @brzvsk,

Great tool, it's exactly what I needed! While using it, I noticed a few minor issues, so I opened this PR with the details and fixes. Please take a look.

Thanks! :)

@tarikbc

tarikbc commented Sep 27, 2026

Copy link
Copy Markdown
Owner

That's awesome. Thanks for contributing!!

@tarikbc
tarikbc merged commit 7d5a12b into tarikbc:main Sep 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants