feat: add maturity#124
Open
SWvheerden wants to merge 4 commits into
Open
Conversation
martinserts
approved these changes
May 20, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces output maturity tracking and a new 'Locked' transaction status to the wallet. Key changes include a database migration to add a maturity column to the outputs table, updates to balance calculation logic to account for immature funds, and enhancements to the transaction processor to handle time-locked outputs. The code review identified several critical issues: the get_output_totals_for_account function incorrectly includes spent outputs in its aggregates, the get_total_unspent_balance function needs to explicitly exclude locked outputs and ensure outputs are confirmed, and the lock_height calculation for pending transactions fails to consider change outputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
add maturity checks to the wallet