Skip to content

feat: add maturity#124

Open
SWvheerden wants to merge 4 commits into
mainfrom
sw_add_maturity
Open

feat: add maturity#124
SWvheerden wants to merge 4 commits into
mainfrom
sw_add_maturity

Conversation

@SWvheerden
Copy link
Copy Markdown
Contributor

Description

add maturity checks to the wallet

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces output maturity tracking and a new 'Locked' transaction status to the wallet. Key changes include a database migration to add a maturity column to the outputs table, updates to balance calculation logic to account for immature funds, and enhancements to the transaction processor to handle time-locked outputs. The code review identified several critical issues: the get_output_totals_for_account function incorrectly includes spent outputs in its aggregates, the get_total_unspent_balance function needs to explicitly exclude locked outputs and ensure outputs are confirmed, and the lock_height calculation for pending transactions fails to consider change outputs.

Comment thread minotari/src/db/outputs.rs
Comment thread minotari/src/db/outputs.rs
Comment thread minotari/src/transactions/manager.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants