This repository was archived by the owner on Feb 11, 2022. It is now read-only.
add tests#11
Open
ilmarkov wants to merge 15 commits into
Open
Conversation
dedok
reviewed
Jan 25, 2017
| -- So you have to ignore them | ||
| -- {{ | ||
| package.preload['curl.driver'] = '../curl/driver.so' | ||
| -- package.preload['curl.driver'] = '../curl/driver.so' |
There was a problem hiding this comment.
It will not work on local environment. For instance, If user has builded curl.driver locally and he has not installed curl.driver into OS.
| @@ -13,33 +13,39 @@ http = curl.http() | |||
| local headers = { my_header = "1", my_header2 = "2" } | |||
| -- So you have to ignore them | ||
| -- {{ | ||
| package.preload['curl.driver'] = 'curl/driver.so' | ||
| -- package.preload['curl.driver'] = 'curl/driver.so' |
| host_good = 'https://httpbin.org/get' | ||
| host_bad = 'https://httpbin.org/not_get' | ||
|
|
||
| --function valid_response_get(value) |
|
|
||
|
|
||
| post_requests = {} | ||
| post_requests["sync_post_request"] = {f = http.sync_post_request, param = nil, host = "https://httpbin.org/post"} |
There was a problem hiding this comment.
A line length shouldn't be more than 80 symbols
| http = curl.http() | ||
|
|
||
| --{{ | ||
| -- Testing sync get calls |
There was a problem hiding this comment.
sync_funcs does not called by this program
| end | ||
| end | ||
|
|
||
| async_funcs = {} |
|
|
||
| function run(desc, func, param) | ||
| print('Running', desc) | ||
| ok, err = func(param) |
There was a problem hiding this comment.
run does not validate result. For instance, user did POST a data and that data has been corrupted by curl.driver (bug and so on).
Well, a good solution is validate a server's output body (echo server) and a client's input only if user's request has a body.
dedok
suggested changes
Feb 6, 2017
| } | ||
| } | ||
| else if (strcmp(method, "PUT") == 0) { | ||
| else if (strcmp(method, "PUT") == 0) { |
| lua_pop(L, 1); | ||
|
|
||
| /* Write callback */ | ||
| /* Write callback */ |
| return true, _ | ||
| end | ||
|
|
||
| --for key, value in pairs(sync_funcs) |
| return ctx.ok, ctx.msg | ||
| end | ||
|
|
||
| --for key, value in pairs(async_funcs) |
| return true | ||
| end | ||
|
|
||
| --for key, value in pairs(post_requests) |
| -- failed (included systeme erros, curl errors, HTTP | ||
| -- erros and so on) | ||
| -- failed (included system erros, curl errors, and so on | ||
| -- but not HTTP errors) |
There was a problem hiding this comment.
Corrected version is - ... and so on. But the counter does not include HTTP errors.
| } | ||
|
|
||
|
|
||
| value_header = "json/application" |
|
Any progress? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.