Repository navigation
fix: return EmptyExec for LIMIT 0 in physical planning - #30
Merged
Merged
Conversation
askalt
reviewed
Aug 21, 2026
|
Can |
Author
|
Short-circuit physical planning when a limit requests zero rows by returning an EmptyExec with the input schema.
karpenkoag
force-pushed
the
a.karpenko/fix-zero-limit-in-plc
branch
from
August 24, 2026 16:38
38b2f40 to
3722229
Compare
Author
At other points, fetch means the sum of limit and offset and is used for pushdown. Previously, fetch =0 fell into the Sort node with "ORDER BY". But Sort and TableScan are deeper than LIMIT in logical plans, and now the case with LIMIT 0 will not reach them. I do not know how to create these nodes directly without a LIMIT. |
askalt
approved these changes
Aug 26, 2026
LLDay
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short-circuit physical planning when a limit requests zero rows by returning an EmptyExec with the input schema.