Skip to content

User Register: API testid ja User Register: Mocked API testid #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GertenP wants to merge 2 commits into from
Closed

User Register: API testid ja User Register: Mocked API testid #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f787c78
User Register. API testid
Apr 8, 2026
7d025c1
fix for ex 1 and 2
Apr 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
188 changes: 155 additions & 33 deletions app.mock.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,59 +1,181 @@
const createApp = require('./app')
const request = require('supertest')
const validateUsername = require('./validation/validateUsername')
const validatePassword = require('./validation/validatePassword')

//Mock validateEmail to isolate tests
const createApp = require('./app');
const request = require('supertest');

jest.mock('./validation/validateEmail', () => {
return jest.fn((email) => {
//Simulate real world simulation
if (!email || typeof email !== 'string') return false;
const re = /^[^\s@]+@[^\s@]+\.[^\s@]{2,}$/i;
return re.test(email);
})
})
return email === 'student@example.com';
});
});

const validateUsername = require('./validation/validateUsername');
const validatePassword = require('./validation/validatePassword');
const validateEmail = require('./validation/validateEmail');

const validateEmail = require('./validation/validateEmail')
const app = createApp(validateUsername, validatePassword, validateEmail)
const app = createApp(validateUsername, validatePassword, validateEmail);

describe('given correct username and password', () => {
test('return status 200', async () => {
const response = await request(app).post('/users').send({
username: 'Username',
password: 'Password123',
email: 'student@example.com'
})
expect(response.statusCode).toBe(200)
})
});
expect(response.statusCode).toBe(200);
});

test('returns userId', async () => {
const response = await request(app).post('/users').send({
username: 'Username',
password: 'Password123',
email: 'student@example.com'
})
});
expect(response.body.userId).toBeDefined();
})
});

test('response content type should be JSON', async () => {
const response = await request(app).post('/users').send({
username: 'Username',
password: 'Password123',
email: 'student@example.com'
});
expect(response.headers['content-type']).toMatch(/json/);
});

// test response content type?
// test response message
// test response user id value
// ...
})
test('response message should be Valid User', async () => {
const response = await request(app).post('/users').send({
username: 'Username',
password: 'Password123',
email: 'student@example.com'
});
expect(response.body).toEqual({ userId: "1", message: "Valid User" });
});

test('user id value should be valid', async () => {
const response = await request(app).post('/users').send({
username: 'Username',
password: 'Password123',
email: 'student@example.com'
});
expect(response.body.userId).toBe("1");
});
});

describe('given incorrect or missing username and password', () => {
test('return status 400', async () => {
const response = await request(app).post('/users').send({
username: 'user',
password: 'password',
email: 'not-an-email'
})
expect(response.statusCode).toBe(400)
})

// test response message
// test that response does NOT have userId
// test incorrect username or password according to requirements
// test missing username or password
// ...
})
});
expect(response.statusCode).toBe(400);
});

test('response message should be Invalid User', async () => {
const response = await request(app).post('/users').send({
username: 'er',
password: 'Password123',
email: 'student@example.com'
});
expect(response.body).toEqual({ error: "Invalid User" });
});

test('response should not have userId', async () => {
const response = await request(app).post('/users').send({
username: 'er',
password: 'Password123',
email: 'student@example.com'
});
expect(response.body.userId).toBeUndefined();
});

test('username too short', async () => {
const response = await request(app).post('/users').send({
username: 'abc',
password: 'Password1',
email: 'student@example.com'
});
expect(response.body.error).toBe('Invalid User');
});

test('username with invalid characters', async () => {
const response = await request(app).post('/users').send({
username: 'Invalid@Name',
password: 'Password1',
email: 'student@example.com'
});
expect(response.body.error).toBe('Invalid User');
});

test('password too short', async () => {
const response = await request(app).post('/users').send({
username: 'ValidUsername',
password: 'Pass1',
email: 'student@example.com'
});
expect(response.body.error).toBe('Invalid User');
});

test('password missing uppercase', async () => {
const response = await request(app).post('/users').send({
username: 'ValidUsername',
password: 'password1',
email: 'student@example.com'
});
expect(response.body.error).toBe('Invalid User');
});

test('password missing lowercase', async () => {
const response = await request(app).post('/users').send({
username: 'ValidUsername',
password: 'PASSWORD1',
email: 'student@example.com'
});
expect(response.body.error).toBe('Invalid User');
});

test('password contains special characters', async () => {
const response = await request(app).post('/users').send({
username: 'ValidUsername',
password: 'Password1!',
email: 'student@example.com'
});
expect(response.body.error).toBe('Invalid User');
});

test('email missing @', async () => {
const response = await request(app).post('/users').send({
username: 'ValidUsername',
password: 'Password1',
email: 'studentexample.com'
});
expect(response.body.error).toBe('Invalid User');
});

test('email invalid domain', async () => {
const response = await request(app).post('/users').send({
username: 'ValidUsername',
password: 'Password1',
email: 'student@example'
});
expect(response.body.error).toBe('Invalid User');
});

test('password missing', async () => {
const response = await request(app).post('/users').send({
username: 'ValidUsername',
password: '',
email: 'student@example.com'
});
expect(response.body.error).toBe('Invalid User');
});

test('username missing', async () => {
const response = await request(app).post('/users').send({
username: '',
password: 'Password1',
email: 'student@example.com'
});
expect(response.body.error).toBe('Invalid User');
});
});
Loading
Loading