Repository navigation
Make three tests that fail only on a Windows host hold there - #3712
Merged
Merged
Conversation
Two compared paths as strings, so a path joined with a backslash on Windows did not match the one the test wrote with slashes. They now compare paths. Six lane checks in wasm_simd_lanes first linked a program for the host, and a Windows host has no sysroot for x86_64-windows-gnu in the test job, so they skip the host half on Windows, decided when the test is compiled.
tamnd
added
kind/bug
4 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"test on windows x86-64" has failed on main for a while with 8 failing tests in three places. None of them is a bug in the compiler, each is a test that asks something a Windows host answers differently.
command::tests::the_line_the_driver_writes_for_wasip1_parsesin rucc-wasm-link andlink::tests::a_gcc_named_with_gcc_toolchain_is_the_one_the_link_usesin rucc-driver compared paths as strings. On Windows a file found under a-Ldirectory, and the GCC version directory, are joined with a\, so/s/lib\libm.adid not equal/s/lib/libm.a. Both now compare paths, which treat either separator the same on Windows and change nothing elsewhere.Six lane checks in crates/rucc/tests/wasm_simd_lanes.rs first build and run the program on the host. The Windows host is x86_64-windows-gnu and the test job fetches no sysroot for it, so the link stopped with "there is no sysroot". The host levels are now a constant that is empty on Windows, decided when the test is compiled as assembler_input.rs does, so a Linux or macOS run cannot quietly stop asserting. The wasm half is gated on WASI_SDK_PATH and wasmtime as before.
On the Linux box the changed tests pass (the rucc-wasm-link command tests, the 88 link tests and all 22 in wasm_simd_lanes) and clippy is clean. The Windows box was not reachable, so the Windows run is what CI says.