Skip to content

chore(cli): prepare npm package for publishing#26

Merged
Abdulmuiz44 merged 1 commit into
mainfrom
chore/codra-cli-publish-readiness
Jun 2, 2026
Merged

chore(cli): prepare npm package for publishing#26
Abdulmuiz44 merged 1 commit into
mainfrom
chore/codra-cli-publish-readiness

Conversation

@Abdulmuiz44
Copy link
Copy Markdown
Collaborator

  • Clarifies @codra/cli publishing readiness.
  • Improves unsupported platform messaging.
  • Documents current single-platform binary packaging limitation.
  • Adds/keeps safe npm pack workflow.
  • Does not publish to npm yet.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 464e26bffb

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +40 to +42
const nativeBins = fileLines.filter((f) => f.startsWith('bin/native/'));
if (nativeBins.length === 0) {
errors.push('no bin/native/<platform>-<arch>/ binary in pack (run npm run build first)');
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Include ignored native binaries in npm packs

Because packages/codra-npm-cli/.gitignore excludes bin/native/, the binary that prepack builds is still omitted from the tarball; I verified npm’s packing behavior by creating a dummy bin/native/.../codra and running npm pack --dry-run --ignore-scripts, whose tarball contents listed only README.md, bin/codra.js, and package.json. As a result this new check always reports no bin/native/... after a successful build, and an actual npm publish would ship a wrapper that cannot run unless the ignore/packaging rules are changed.

Useful? React with 👍 / 👎.

@Abdulmuiz44 Abdulmuiz44 merged commit 8128876 into main Jun 2, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant