Add lifecycle regression tests and fix focus and layout recovery

[talayash]

Adds 50 tests across seven suites for session notifications, focus lifecycle, activity timers, reload protection, tab transfers, window-layout persistence, and paste history.

The regression tests exposed focus listeners registering after unmount, stale initial focus queries overwriting newer events, and malformed saved layouts breaking restoration. This change fixes those cases, adds the analytics worker suite to CI, and records prioritized coverage gaps in docs/testing-audit.md.

Validation:

• Frontend: 554 tests passed across 65 files (previously 504 across 58).
• Rust: 267 tests passed with cargo test --locked --offline.
• Analytics worker: 15 tests passed.
• TypeScript and production build passed; Vite reports large chunks and ineffective dynamic imports.
• git diff --check passed.

Desktop integration tests mock Tauri boundaries. Packaged-app end-to-end coverage and native window/PTY interactions remain follow-up work documented in the audit.

[ecc-tools]

ECC Tools / Security Evidence

Commit: b1491227fd71648b4c458a2691a091a03c582bcf

Security scanner evidence required (action_required)

Detected 1 security-sensitive predictive risk signal(s) without scanner evidence.

Mode: enforce

Findings:

• Security-sensitive changes may ship without scanner evidence: The PR touches billing, secrets, auth, webhooks, agent, or CI-sensitive surfaces without adding obvious security scanner, code scanning, or security-focused validation evidence. (5 security-sensitive paths changed; 0 security scanner or security-focused validation artifacts changed)

Touched security-sensitive paths:

• src/hooks/useNowTick.test.ts
• src/hooks/usePreventWebviewReload.test.ts

Expected evidence:

• Security scanner, code scanning, secret scanning, dependency/security review, or focused security regression output.
• SARIF/code-scanning upload or equivalent pass/fail gate for the changed surface.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / PR Risk Taxonomy

Commit: b1491227fd71648b4c458a2691a091a03c582bcf

PR taxonomy review recommended (neutral)

Detected 2 PR taxonomy bucket(s): Security Evidence, CI/CD Recommendation.

Scanned 11 changed file(s).

Roadmap taxonomy buckets:

Security Evidence

Security-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence.

Signals:

• Security-sensitive changes may ship without scanner evidence
• 1 security-sensitive path(s) changed

Paths:

• .github/workflows/ci.yml

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

• CI workflow changes may ship without failure-mode evidence
• Dependency or CI drift could surface after merge
• 8 CI or workflow path(s) changed

Paths:

• .github/workflows/ci.yml
• src/hooks/useNowTick.test.ts
• src/hooks/usePreventWebviewReload.test.ts
• src/hooks/useSessionStateDetection.test.ts
• src/hooks/useWindowFocused.test.ts
• src/lib/tabTransfer.test.ts
• src/lib/windowLayout.test.ts
• src/store/pasteStore.test.ts

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / Reference Set Readiness

Commit: b1491227fd71648b4c458a2691a091a03c582bcf

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 11 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area	Status	Evidence / Next Step
Deep analyzer corpus	Missing	Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison	Missing	Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus	Missing	Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus	Missing	Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility	Missing	Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence	Missing	Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence	Missing	Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / Hosted Promotion Readiness

Commit: b1491227fd71648b4c458a2691a091a03c582bcf

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 11 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / PR Config Audit

Commit: b1491227fd71648b4c458a2691a091a03c582bcf

No changed-config issues detected (success)

Scanned 1 config file(s) present at this commit across 1 changed config path(s) and found no issues in the supported security rules.

Changed config files:

• .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / PR Harness Audit

Commit: b1491227fd71648b4c458a2691a091a03c582bcf

No harness issues detected (success)

Scanned 1 changed config file(s) and found no harness issues.

Changed config files:

• .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / Security Evidence

Commit: 0222f1aa37c7a9ece4946ee6ce334b61cab30128

Security scanner evidence required (action_required)

Detected 1 security-sensitive predictive risk signal(s) without scanner evidence.

Mode: enforce

Findings:

• Security-sensitive changes may ship without scanner evidence: The PR touches billing, secrets, auth, webhooks, agent, or CI-sensitive surfaces without adding obvious security scanner, code scanning, or security-focused validation evidence. (5 security-sensitive paths changed; 0 security scanner or security-focused validation artifacts changed)

Touched security-sensitive paths:

• src/hooks/useNowTick.test.ts
• src/hooks/usePreventWebviewReload.test.ts

Expected evidence:

• Security scanner, code scanning, secret scanning, dependency/security review, or focused security regression output.
• SARIF/code-scanning upload or equivalent pass/fail gate for the changed surface.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / PR Risk Taxonomy

Commit: 0222f1aa37c7a9ece4946ee6ce334b61cab30128

PR taxonomy review recommended (neutral)

Detected 2 PR taxonomy bucket(s): Security Evidence, CI/CD Recommendation.

Scanned 12 changed file(s).

Roadmap taxonomy buckets:

Security Evidence

Security-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence.

Signals:

• Security-sensitive changes may ship without scanner evidence
• 1 security-sensitive path(s) changed

Paths:

• .github/workflows/ci.yml

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

• Runtime config changes may ship without example or template updates
• Async job or webhook changes may ship without reliability coverage
• CI workflow changes may ship without failure-mode evidence
• Dependency or CI drift could surface after merge
• 8 CI or workflow path(s) changed

Paths:

• .github/workflows/ci.yml
• src/hooks/useNowTick.test.ts
• src/hooks/usePreventWebviewReload.test.ts
• src/hooks/useSessionStateDetection.test.ts
• src/hooks/useWindowFocused.test.ts
• src/lib/tabTransfer.test.ts
• src/lib/windowLayout.test.ts
• src/store/pasteStore.test.ts

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / Reference Set Readiness

Commit: 0222f1aa37c7a9ece4946ee6ce334b61cab30128

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 12 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area	Status	Evidence / Next Step
Deep analyzer corpus	Missing	Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison	Missing	Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus	Missing	Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus	Missing	Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility	Missing	Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence	Missing	Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence	Missing	Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / Hosted Promotion Readiness

Commit: 0222f1aa37c7a9ece4946ee6ce334b61cab30128

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 12 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / PR Config Audit

Commit: 0222f1aa37c7a9ece4946ee6ce334b61cab30128

No changed-config issues detected (success)

Scanned 1 config file(s) present at this commit across 1 changed config path(s) and found no issues in the supported security rules.

Changed config files:

• .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / PR Harness Audit

Commit: 0222f1aa37c7a9ece4946ee6ce334b61cab30128

No harness issues detected (success)

Scanned 1 changed config file(s) and found no harness issues.

Changed config files:

• .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / Security Evidence

Commit: f060cabc84a511b1ddb6901be225736f84fa7619

Security scanner evidence required (action_required)

Detected 1 security-sensitive predictive risk signal(s) without scanner evidence.

Mode: enforce

Findings:

• Security-sensitive changes may ship without scanner evidence: The PR touches billing, secrets, auth, webhooks, agent, or CI-sensitive surfaces without adding obvious security scanner, code scanning, or security-focused validation evidence. (5 security-sensitive paths changed; 0 security scanner or security-focused validation artifacts changed)

Touched security-sensitive paths:

• src/hooks/useNowTick.test.ts
• src/hooks/usePreventWebviewReload.test.ts

Expected evidence:

• Security scanner, code scanning, secret scanning, dependency/security review, or focused security regression output.
• SARIF/code-scanning upload or equivalent pass/fail gate for the changed surface.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / PR Risk Taxonomy

Commit: f060cabc84a511b1ddb6901be225736f84fa7619

PR taxonomy review recommended (neutral)

Detected 2 PR taxonomy bucket(s): Security Evidence, CI/CD Recommendation.

Scanned 12 changed file(s).

Roadmap taxonomy buckets:

Security Evidence

Security-sensitive changes should carry explicit scanner, code-scanning, or focused regression evidence.

Signals:

• Security-sensitive changes may ship without scanner evidence
• 1 security-sensitive path(s) changed

Paths:

• .github/workflows/ci.yml

CI/CD Recommendation

CI, dependency, coverage, and contract signals should be routed into follow-up checks or verification work.

Signals:

• Runtime config changes may ship without example or template updates
• Async job or webhook changes may ship without reliability coverage
• CI workflow changes may ship without failure-mode evidence
• Dependency or CI drift could surface after merge
• 8 CI or workflow path(s) changed

Paths:

• .github/workflows/ci.yml
• src/hooks/useNowTick.test.ts
• src/hooks/usePreventWebviewReload.test.ts
• src/hooks/useSessionStateDetection.test.ts
• src/hooks/useWindowFocused.test.ts
• src/lib/tabTransfer.test.ts
• src/lib/windowLayout.test.ts
• src/store/pasteStore.test.ts

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / Reference Set Readiness

Commit: f060cabc84a511b1ddb6901be225736f84fa7619

Reference set readiness gaps detected (neutral)

Reference evidence present for 0/7 areas (0%) across 12 changed file(s).

This check is based on files changed in this PR. Repository-level readiness is still reported by /ecc-tools analyze comments and generated manifests.

Area	Status	Evidence / Next Step
Deep analyzer corpus	Missing	Add analyzer fixture, golden, benchmark, or reference-set files that can catch analyzer regressions.
RAG/evaluator comparison	Missing	Add retrieval or evaluator reference-set comparison fixtures with expected ranking behavior.
PR salvage/review corpus	Missing	Add stale-PR, review-thread, reopen-flow, or salvage reference cases for queue cleanup automation.
Discussion triage corpus	Missing	Add public discussion triage fixtures, golden cases, or reference sets for informational, answered, and no-response classifications.
Harness compatibility	Missing	Add cross-harness, adapter-compliance, or harness-audit evidence for Claude, Codex, OpenCode, Zed, dmux, and agent surfaces.
Security evidence	Missing	Attach security evidence such as SBOMs, SARIF, audit reports, or AgentShield evidence packs.
CI failure-mode evidence	Missing	Add captured CI failure logs, dry-run fixtures, or troubleshooting docs for common workflow failure modes.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / Hosted Promotion Readiness

Commit: f060cabc84a511b1ddb6901be225736f84fa7619

Hosted promotion readiness passed (success)

No hosted promotion evidence gaps detected across 12 changed file(s); 0 corpus scenarios had matching evidence.

This check compares PR file changes against the evaluator/RAG promotion corpus in src/analyzers/fixtures/evaluator-rag-corpus.ts.
Hosted output scoring inspected 0 completed cached hosted job results.

No evaluator corpus scenarios matched this PR.

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / PR Config Audit

Commit: f060cabc84a511b1ddb6901be225736f84fa7619

No changed-config issues detected (success)

Scanned 1 config file(s) present at this commit across 1 changed config path(s) and found no issues in the supported security rules.

Changed config files:

• .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.

[ecc-tools]

ECC Tools / PR Harness Audit

Commit: f060cabc84a511b1ddb6901be225736f84fa7619

No harness issues detected (success)

Scanned 1 changed config file(s) and found no harness issues.

Changed config files:

• .github/workflows/ci.yml

Check publication was denied or unavailable. An app owner must enable Checks: read and write, and the installation owner must approve the updated permission.