tailcat: reject malformed ConnBlob public keys - #26
Merged
bradfitz merged 1 commit intoAug 30, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject malformed public keys embedded in connection blobs instead of panicking during CBOR decoding.
Details
NodePublic.UnmarshalBinarypassed arbitrary CBOR byte strings directly tokey.NodePublicFromRaw32, which panics unless the input is exactly 32 bytes.Connection blobs can be supplied by users or discovered through DNS TXT records, so malformed input could terminate the CLI or a library process.
This change validates the byte-string length first and returns a descriptive error. Regression tests cover both short and oversized public keys through
ParseConnBlobandParseConnBlobRaw.Testing
go test . -run TestParseConnBlobMalformedPublicKey -count=1go test . -run TestConnBlob -count=1go test . -count=1