Repository navigation
openspec: propose monitor management UI - #4
Merged
Merged
Conversation
Add the add-monitor-ui change. It proposes an opt-in --ui flag that serves a small embedded single-page app and a JSON API under /api/v1/ for adding, editing and deleting monitors on a running collector. UI-created monitors persist in state_dir/targets.json and overlay the YAML targets, which stay read-only. Deleting a DOWN monitor closes its incident with reason removed. Access control is the tailnet ACL for now, behind a single authorize hook. The change deviates from the design doc's web UI non-goal; the deviation is recorded in design.md. Its deltas modify specs that the add-notifications change archives, so it applies once that change lands. Updates tailscale/tailscale#5967 Signed-off-by: Richard Shade <rshade98@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the add-monitor-ui change. It proposes an opt-in --ui flag that serves a small embedded single-page app and a JSON API under /api/v1/ for adding, editing and deleting monitors on a running collector.
UI-created monitors persist in state_dir/targets.json and overlay the YAML targets, which stay read-only. Deleting a DOWN monitor closes its incident with reason removed. Access control is the tailnet ACL for now, behind a single authorize hook.
The change deviates from the design doc's web UI non-goal; the deviation is recorded in design.md. Its deltas modify specs that the add-notifications change archives, so it applies once that change lands.
Updates tailscale/tailscale#5967