Skip to content

fix(types): remove non-existent updatedAt from tailor.idp.User#180

Merged
k1LoW merged 1 commit into
mainfrom
fix/types/remove-user-updated-at
Jun 3, 2026
Merged

fix(types): remove non-existent updatedAt from tailor.idp.User#180
k1LoW merged 1 commit into
mainfrom
fix/types/remove-user-updated-at

Conversation

@k1LoW
Copy link
Copy Markdown
Contributor

@k1LoW k1LoW commented Jun 3, 2026

Summary

  • Remove updatedAt?: string from tailor.idp.User because the IDP service does not return this field
  • The declaration was misleading consumers into expecting an optional timestamp that was always undefined

The `updatedAt` field is declared on the `User` interface but is not
returned by the IDP service, so any type-driven access yielded
`undefined` and misled consumers. Drop it from the type so the
declaration matches the runtime response.
@k1LoW k1LoW self-assigned this Jun 3, 2026
@k1LoW k1LoW added the bug Something isn't working label Jun 3, 2026
@k1LoW k1LoW requested a review from Copilot June 3, 2026 01:27
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the misleading updatedAt?: string property from the tailor.idp.User ambient type so TypeScript consumers don’t assume an IDP field that is never present.

Changes:

  • Remove updatedAt?: string from tailor.idp.User in the types declaration file.
  • Add a Changesets entry to publish the fix as a patch release of @tailor-platform/function-types.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
packages/types/tailor.d.ts Removes the non-existent updatedAt field from tailor.idp.User.
.changeset/remove-user-updated-at.md Adds a patch changeset describing the types fix for release notes/versioning.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@k1LoW k1LoW marked this pull request as ready for review June 3, 2026 01:31
@k1LoW k1LoW requested a review from a team as a code owner June 3, 2026 01:31
k1LoW added a commit to tailor-platform/sdk that referenced this pull request Jun 3, 2026
The IDP service does not return an `updatedAt` field, but the
`idp.User` interface declared `updatedAt?: string`. Consumers were
misled into expecting an optional timestamp that was always
`undefined` at runtime.

Mirrors tailor-platform/function#180, which removed the same field
from `tailor.idp.User` in the function-types package.
Copy link
Copy Markdown
Contributor

@toiroakr toiroakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@toiroakr toiroakr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k1LoW k1LoW merged commit a36c24f into main Jun 3, 2026
7 checks passed
@k1LoW k1LoW deleted the fix/types/remove-user-updated-at branch June 3, 2026 05:07
@github-actions github-actions Bot mentioned this pull request Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants