Fix "random panic" in DecodeScalar#29
Open
the-eater wants to merge 1 commit intotailhook:mainfrom
Open
Conversation
…ing on default implementation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently you can force a panic while decoding a
Valuewrapped in a container because all containers delegatedecodeto the default implementation, whileValueonly accepts callingdecodedirectly,This PR makes all containers call
::decodeof their child type insteadcode proof
I would also like to note that the trait for
DecodeScalarseems, confusing?it's advised not to implement
::decodeby hand, however there's no access to the type name in::raw_decode, requiring weird workarounds to implement a polymorphic scalar while also following said adviceI e.g. currently want to support the following:
this either requires storing a
MyScalarTypeenum in the context, or not following given advice lol