fix(markdown): preserve korean spacing in wrapped structured output#2909
Open
iosif2 wants to merge 4 commits intotailcallhq:mainfrom
Open
fix(markdown): preserve korean spacing in wrapped structured output#2909iosif2 wants to merge 4 commits intotailcallhq:mainfrom
iosif2 wants to merge 4 commits intotailcallhq:mainfrom
Conversation
1b34ef7 to
1352cd6
Compare
1352cd6 to
fb98366
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Korean spacing being lost in wrapped structured markdown output, most visibly in numbered and bulleted content.
Context
Korean text could lose explicit spaces while wrapping streamed markdown output.
The issue was most visible in structured body content such as numbered lists and bullet lists, where wrapped lines could be reflowed with incorrect separator handling. The same wrapping behavior also affected other wrapped markdown surfaces.
Changes
forge_markdown_streamKey Implementation Details
The main user-visible failure happened in structured body content, especially list-style output.
The fix centralizes wrapping behavior in
forge_markdown_stream/src/utils.rsso explicit separators are preserved consistently instead of being reconstructed differently across render paths. Headings were updated as part of the same wrapping path cleanup, but they were not the primary symptom.Before / After
Manually compared the released
forgebinary against a locally builtforgebinary by entering the same prompts inside Forge directly.Example prompt entered inside Forge:
Before
Numbered lists:
Bullet lists:
### 1. 코드베이스 분석 • 프로젝트구조파악 • 특정기능이어디서구현되는지추적 • 에러처리흐름,데이터흐름,모듈관계분석 • “이코드가왜이렇게동작하는지”조사 이 저장소는 주로 Rust 워크스페이스이고, 보조적으로 TypeScript 벤치마크 도구와 Zsh 셸 플러그인도 포함합니다.After
Numbered lists:
Bullet lists:
This example uses Korean text to show that explicit spaces are now preserved during wrapping.
Testing
cargo check -p forge_markdown_stream cargo test -p forge_markdown_streamAdded regression coverage for: