Skip to content

Upgrade PyInstaller 5.13.1 to 6.22.3 - #489

Merged
bcantoni merged 1 commit into
developmentfrom
jac/pyinstaller-6-on-development
Oct 27, 2026
Merged

bcantoni merged 1 commit into
developmentfrom
jac/pyinstaller-6-on-development

Conversation

@jacalata

Copy link
Copy Markdown
Contributor

Upgrades PyInstaller from 5.13.1 to 6.22.3, based on development.

  • pyproject.toml: pyinstaller==6.22.3, and setuptools==83.0.0 in the package extra. The setuptools pin is what the four-platform run tested.
  • tabcmd-{windows,mac,linux}.spec: drop the requests.packages.urllib3 and pkg_resources hidden imports, which PyInstaller 6 no longer needs.
  • package.yml: add a smoke test step that runs -v, then a login against a closed port and checks it fails with a connection error rather than an import error. This catches missing bundled modules (requests, urllib3, certifi).

Supersedes #487, which was built on main.

🤖 Generated with Claude Code

Drop the hidden imports PyInstaller 6 no longer needs (requests.packages.urllib3,
pkg_resources), which removes the reason for the setuptools==81 pin. Add a
Package-and-Upload step that runs -v and a failing login against a closed port,
to catch missing bundled modules (requests, urllib3, certifi).

Co-Authored-By: Claude Code <noreply@anthropic.com>
Copilot AI balanced review requested due to automatic review settings October 26, 2026 21:42

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

@github-actions

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
tabcmd
   __main__.py121212 0%
   _version.py111111 0%
   tabcmd.py151515 0%
   version.py1066 40%
tabcmd/commands
   commands.py101010 0%
   constants.py771818 77%
   server.py1351818 87%
tabcmd/commands/auth
   session.py3945050 87%
tabcmd/commands/datasources_and_workbooks
   datasources_and_workbooks_command.py1571818 89%
   datasources_workbooks_views_url_parser.py14255 96%
   delete_command.py702323 67%
   export_command.py1202525 79%
   get_url_command.py1274747 63%
   publish_command.py1341616 88%
   runschedule_command.py2177 67%
tabcmd/commands/extracts
   create_extracts_command.py4288 81%
   decrypt_extracts_command.py2722 93%
   delete_extracts_command.py3766 84%
   encrypt_extracts_command.py2722 93%
   extracts.py2022 90%
   reencrypt_extracts_command.py2722 93%
   refresh_extracts_command.py481010 79%
tabcmd/commands/group
   create_group_command.py2955 83%
   delete_group_command.py2722 93%
tabcmd/commands/project
   create_project_command.py4688 83%
   delete_project_command.py3544 89%
   publish_samples_command.py3044 87%
tabcmd/commands/site
   create_site_command.py3455 85%
   delete_site_command.py2722 93%
   edit_site_command.py661818 73%
   list_command.py771212 84%
   list_sites_command.py2922 93%
tabcmd/commands/user
   add_users_command.py2955 83%
   create_site_users.py581111 81%
   create_users_command.py5999 85%
   delete_site_users_command.py4355 88%
   user_data.py2223131 86%
tabcmd/execution
   _version.py222 0%
   global_options.py14788 95%
   localize.py671111 84%
   logger_config.py6066 90%
   tabcmd_controller.py4277 83%
TOTAL294647084% 

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Packaging checks passed on the superseded branch, but equivalent validation is not established for this development-based revision.

No open issues 🎉

Review effort: Balanced

@bcantoni
bcantoni merged commit 9cdbd2b into development Oct 27, 2026
23 checks passed
@bcantoni
bcantoni deleted the jac/pyinstaller-6-on-development branch October 27, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants