Repository navigation
Stop committing generated .mo files; build them with doit localize - #488
Merged
Merged
Conversation
The .mo bundles are generated from the .properties files, and every PR that changed a string regenerated them, so they conflicted constantly. Untrack them, ignore them, and run doit localize before building in CI and packaging. Remove check-mo-freshness, which has nothing left to check. Co-Authored-By: Claude Code <noreply@anthropic.com>
Untracking the .mo files left the LC_MESSAGES directories empty, and git does not store empty directories, so doit localize failed on a fresh checkout. Co-Authored-By: Claude Code <noreply@anthropic.com>
bcantoni
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops committing the generated
.motranslation bundles. They are built from the.propertiesfiles bydoit localize, and every PR that changed a string regenerated them, so open PRs conflict on them constantly.tabcmd/locales/*/LC_MESSAGES/tabcmd.mofiles and addtabcmd/locales/**/*.moto.gitignore.pip install .[localize]anddoit localizebeforepip install .inrun-tests,check-coverage,generate-metadata,run-e2-tests,packageandpublish-pypi, so the bundles exist for tests,python -m buildand PyInstaller.MANIFEST.inwithrecursive-include tabcmd/locales *.moso the sdist carries the generated files.check-mo-freshness.yml, which has nothing left to check.bin/i18n/README.mdandcontributing.md.Open PRs that changed a
.mofile need one more merge ofdevelopmentafter this lands. The conflict is modify/delete and resolves withgit rmon the.mofile.The workflow edits can only be exercised in CI. Worth running Package-and-Upload from this branch to confirm the packaged binaries still ship translations.
🤖 Generated with Claude Code