Repository navigation
Conversation
This reverts commit ddd1b24.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The targeted dependency rollback has no identified blocking issues, and the linked packaging workflow completed successfully.
0 open findings
What changed in this PR
Restores packaging compatibility with PyInstaller 5.13.1 while the PyInstaller 6 upgrade remains deferred.
Changes:
- Reverts the packaging extra’s setuptools pin from 83.0.0 to 81 to restore
pkg_resources.
| File | Description |
|---|---|
| pyproject.toml | Pins setuptools to 81 for packaging compatibility. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct revert of #461's setuptools 81→83.0.0 bump. setuptools 82+ dropped the bundled pkg_resources shim; pyinstaller 5.13.1 still imports it directly, so package.yml's builds fail with
ModuleNotFoundError: No module named 'pkg_resources'on every platform. Confirmed via workflow_dispatch run (all four legs green): https://github.com/tableau/tabcmd/actions/runs/38852580921package.yml only runs on tag push or workflow_dispatch, so this went undetected by normal PR CI since #461 merged.
This is a stopgap, not a long-term fix — pkg_resources is slated for removal from pip entirely as early as 2025-11-30. The real fix is the pyinstaller 6.0 upgrade (#477), which needs matching changes for pyinstaller 6's macOS .app bundle restructuring before it's usable. Raising priority on that.
🤖 Generated with Claude Code