Repository navigation
Conversation
…coding in doit localize Untranslated keys currently show as the raw .properties key until the next bulk .mo regeneration touches that locale. Fall back to the English catalog instead so users see real text in the interim. Also fixes a Windows-only cosmetic issue: doit localize's check_mo task prints ja/ko/zh sample text that cp1252 consoles can't encode, raising charmap errors during validation. Force UTF-8 on the console streams doit actually writes to. Co-Authored-By: Claude Code <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped, fallback behavior was verified, and no blocking issues were identified.
0 open findings
What changed in this PR
Adds English fallback text for untranslated tabcmd messages and fixes Windows encoding errors during localization validation.
Changes:
- Adds the English catalog as a fallback for non-English locales.
- Adds a regression test for untranslated messages.
- Configures validation output streams to use UTF-8.
| File | Description |
|---|---|
| tests/test_localize.py | Tests fallback text and placeholder preservation. |
| tabcmd/execution/localize.py | Adds English catalog fallback. |
| dodo.py | Enables UTF-8 output during catalog validation. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Closing as a duplicate of #440, which does the same English-fallback fix plus a check-mo-freshness CI workflow and the full locale .mo regeneration. Continuing there instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Untranslated keys currently show as the raw .properties key until the next bulk .mo regeneration touches that locale. Falls back to the English catalog instead so users see real text in the interim.
Also fixes a Windows-only cosmetic issue: doit localize's check_mo task prints ja/ko/zh sample text that cp1252 consoles can't encode, raising charmap errors during validation. Forces UTF-8 on the console streams doit actually writes to.
This branch will also carry the full multi-locale .mo regeneration once #446, #448, #449, #432, and #455 have landed.
🤖 Generated with Claude Code