fix: correct and standardize tabcmd 2 output messages to match tabcmd 1 by jacalata · Pull Request #432 · tableau/tabcmd

jacalata · 2026-07-22T05:39:17Z

Closes items 1-9 in #429 (item #10, logout redirect, is not applicable with PAT auth).

Motivation

#429 catalogued a set of output-message bugs where tabcmd 2 diverged from tabcmd 1. Fixing them one at a time would be nine small PRs; the changes all touch the same formatter or locale-key wiring, so a single PR is fine.

Behavior change

For users:

INFO log lines now render with tabcmd 1's ===== prefix by default
(item Creategroup command #8 in the issue). Users who prefer the plainer tabcmd 2 style can
opt out with TABCMD_CLASSIC_OUTPUT=false.
listsites output shows human-readable SITEID instead of the site UUID.
deletegroup status message uses the group name, not a UUID.
createsiteusers error list shows human-readable messages, not the
raw exception class name.
removeusers uses the correct locale key (removeusers.group).
Export save message and delete status message no longer render a
double-space when content type is empty.
Login prints a Signing in... status line, matching tabcmd 1.
Saved X to 'Y' renders X = content name, Y = destination path
(previously both slots rendered the destination).
Debug detail lines (Fetched user details, error-message detail)
demoted from INFO to DEBUG.
The spurious logging: INFO line no longer appears before every
command (type mismatch: namespace.logging_level is the string
"INFO" but was compared against logging.INFO, integer 20; always
truthy).

The ===== prefix is implemented via a single logger_config.py
formatter change so we don't have to edit every locale string.

Test plan

All 339 existing unit tests pass, plus 2 new save_to_file tests
covering the content_name parameter
Manual: tabcmd login / tabcmd logout with default settings
produce =====-prefixed output
Manual: TABCMD_CLASSIC_OUTPUT=false tabcmd login produces plain
output without the prefix
tabcmd listsites shows human-readable SITEID
No logging: INFO line appears before command output

🤖 Generated with Claude Code

…esiteusers, removeusers - listsites: show site content_url instead of internal UUID for SITEID - deletegroup: log group name instead of UUID in delete status message - export/save_to_file: pass filename as content name to fix double-space in "Saved to '...'" message - createsiteusers: append str(e) to error_list instead of e.__class__.__name__ so error details show readable messages - removeusers: use new tabcmd.removeusers.group string key that includes the group name in the status message Fixes #429 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…ebug noise - logger_config.py: add ===== prefix to INFO format so all action lines match tabcmd 1 style in one place - session.py: remove hardcoded ===== from _print_server_info lines (now added by formatter); demote "Fetched user details from server" to debug - constants.py: demote tabcmd.debug.error_message log call from info to debug so it no longer appears in normal output - delete_command.py: default content_type to "workbook" in status message to fix double-space when type is undetected - tabcmd_messages_en.properties: remove hardcoded ===== from tabcmd.listing.header (would double-prefix with formatter) Closes remaining items from #429 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Avoids the ===== prefix being applied to the version/help display. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Plain output is the default. Set TABCMD_CLASSIC_OUTPUT=true (or 1/yes) to restore the ===== prefix on all INFO-level messages for backward compatibility with tabcmd 1 output style. Also moves the version banner in tabcmd_controller to print() so it is never prefixed regardless of mode. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

The condition compared logging_level string 'INFO' to the integer logging.INFO (20), which was always True, causing the print to fire on every invocation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

session.login string already existed; add logger.info call at the start of _sign_in() to surface it as a distinct step after connecting. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

github-actions · 2026-07-22T05:40:21Z

Coverage Report

File	Stmts	Miss	Cover	Missing
tabcmd
__main__.py	12	12	12	0%
_version.py	11	11	11	0%
tabcmd.py	15	15	15	0%
version.py	9	5	5	44%
tabcmd/commands
commands.py	10	10	10	0%
constants.py	77	18	18	77%
server.py	135	18	18	87%
tabcmd/commands/auth
session.py	395	50	50	87%
tabcmd/commands/datasources_and_workbooks
datasources_and_workbooks_command.py	157	18	18	89%
datasources_workbooks_views_url_parser.py	142	5	5	96%
delete_command.py	61	16	16	74%
export_command.py	122	25	25	80%
get_url_command.py	127	47	47	63%
publish_command.py	125	29	29	77%
runschedule_command.py	21	7	7	67%
tabcmd/commands/extracts
create_extracts_command.py	42	8	8	81%
decrypt_extracts_command.py	27	2	2	93%
delete_extracts_command.py	37	6	6	84%
encrypt_extracts_command.py	27	2	2	93%
extracts.py	20	2	2	90%
reencrypt_extracts_command.py	27	2	2	93%
refresh_extracts_command.py	48	10	10	79%
tabcmd/commands/group
create_group_command.py	29	5	5	83%
delete_group_command.py	27	2	2	93%
tabcmd/commands/project
create_project_command.py	46	8	8	83%
delete_project_command.py	35	4	4	89%
publish_samples_command.py	30	4	4	87%
tabcmd/commands/site
create_site_command.py	34	5	5	85%
delete_site_command.py	27	2	2	93%
edit_site_command.py	38	2	2	95%
list_command.py	77	12	12	84%
list_sites_command.py	29	2	2	93%
tabcmd/commands/user
add_users_command.py	29	5	5	83%
create_site_users.py	58	11	11	81%
create_users_command.py	59	9	9	85%
delete_site_users_command.py	43	5	5	88%
user_data.py	222	31	31	86%
tabcmd/execution
_version.py	2	2	2	0%
global_options.py	126	8	8	94%
localize.py	66	11	11	83%
logger_config.py	62	6	6	90%
tabcmd_controller.py	40	7	7	82%
TOTAL	2880	459	84%

bcantoni · 2026-07-25T00:41:18Z

@jacalata looks good - my only question, do we need tabcmd.removeusers.group added to the other language files too?

jacalata · 2026-07-27T21:53:29Z

@jacalata looks good - my only question, do we need tabcmd.removeusers.group added to the other language files too?

good question. I thought we had a fallback, but we don't. I've implemented that now in #440

Two follow-up fixes for parity with tabcmd Classic output: - save_to_file/save_to_data_file previously passed filename twice into the "Saved {0} to '{1}'" template, so both slots rendered the same path. Classic output was "Saved <content-name> to '<destination>'" where the two are distinct. Add a content_name parameter and thread export_item.name / get_url_item.name from all four callers. - TABCMD_CLASSIC_OUTPUT default flipped to true. The stated goal of this PR is parity with tabcmd 1 output, and issue #429 item 8 lists the missing "=====" prefix as a bug. Users who prefer the plainer tabcmd 2 style can opt out with TABCMD_CLASSIC_OUTPUT=false. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Copilot

Copilot review overview

🟡 Changes recommended

Localization catalogs and delete/list output handling remain incomplete or incorrect.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 3 · 1

Open (4)

Report resolved content type in removal status · New
Use resource name instead of full project path in status · New
Add removeusers fallback key to all locale catalogs · New
Remove leading space from localized listsites message · New

What changed in this PR

This PR standardizes tabcmd 2 output to match tabcmd 1, including classic prefixes, corrected identifiers, messages, logging levels, and export naming.

Changes:

Added configurable classic INFO formatting.
Corrected site, group, user, delete, login, and export messages.
Added export filename/content-name tests and localization updates.

File	Description
`tests/commands/test_geturl_utils.py`	Tests export success-message naming.
`tabcmd/locales/en/tabcmd_messages_en.properties`	Updates listing and remove-users messages.
`tabcmd/execution/tabcmd_controller.py`	Removes spurious logging output.
`tabcmd/execution/parent_parser.py`	Prints help directly.
`tabcmd/execution/logger_config.py`	Adds configurable classic prefixes.
`tabcmd/commands/user/remove_users_command.py`	Uses group-specific message key.
`tabcmd/commands/user/create_site_users.py`	Reports readable exceptions.
`tabcmd/commands/site/list_sites_command.py`	Displays site content URLs.
`tabcmd/commands/group/delete_group_command.py`	Displays group names.
`tabcmd/commands/datasources_and_workbooks/get_url_command.py`	Passes content names to save helpers.
`tabcmd/commands/datasources_and_workbooks/export_command.py`	Tracks exported content names.
`tabcmd/commands/datasources_and_workbooks/delete_command.py`	Avoids empty delete content types.
`tabcmd/commands/datasources_and_workbooks/datasources_and_workbooks_command.py`	Supports content-aware save messages.
`tabcmd/commands/constants.py`	Demotes error details to DEBUG.
`tabcmd/commands/auth/session.py`	Adjusts login and session output.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

 tabcmd.refresh.options.bridge=Refresh datasource through Tableau Bridge
 tabcmd.removeusers.help.group_name=The group to remove users from
 tabcmd.removeusers.server=Removing users listed in {0} from the server...
+tabcmd.removeusers.group=Removing users listed in {0} from the group ''{1}''...


- delete_command.py: initialize item_to_delete before conditional; move delete.status log after item resolution so content_type/name are populated. - dodo.py: fix NameError in uniquify_file - reference unique_lines (the sorted list actually printed) instead of undefined uniques. - en properties: strip stray leading space in tabcmd.listing.header format string. - locales: regenerated .mo/.properties for all languages.

Copilot

Copilot review overview

🔵 Needs a closer look

Runtime gettext catalogs are not regenerated, so the locale output fixes are not active and may produce stale or raw-key messages.

Review effort: Lite
Findings: 1

Open (1)

Add removeusers fallback key to all locale catalogs

Resolved since last review (3)

Use resource name instead of full project path in status
Report resolved content type in removal status
Remove leading space from localized listsites message

bcantoni · 2026-10-14T05:37:22Z

@copilot resolve the merge conflicts in this pull request

…-messages # Conflicts: # tabcmd/locales/de/LC_MESSAGES/tabcmd.mo # tabcmd/locales/en/LC_MESSAGES/tabcmd.mo # tabcmd/locales/es/LC_MESSAGES/tabcmd.mo # tabcmd/locales/fr/LC_MESSAGES/tabcmd.mo # tabcmd/locales/ga/LC_MESSAGES/tabcmd.mo # tabcmd/locales/it/LC_MESSAGES/tabcmd.mo # tabcmd/locales/ja/LC_MESSAGES/tabcmd.mo # tabcmd/locales/ko/LC_MESSAGES/tabcmd.mo # tabcmd/locales/pt/LC_MESSAGES/tabcmd.mo # tabcmd/locales/sv/LC_MESSAGES/tabcmd.mo # tabcmd/locales/zh/LC_MESSAGES/tabcmd.mo Co-authored-by: bcantoni <58372+bcantoni@users.noreply.github.com>

Copilot · 2026-10-14T05:41:35Z

@copilot resolve the merge conflicts in this pull request

Merged development and resolved the gettext catalog conflicts by regenerating the catalogs from the merged locale sources. Merge commit: 7412ea1.

Copilot

🟡 Changes recommended

Preserve classic INFO formatting for DEBUG configurations and add coverage for the formatter opt-out behavior.

2 open findings

🧠 Review effort: Lite

bcantoni · 2026-10-14T05:48:19Z

    logging.ERROR: "%(asctime)s %(levelname)-5s:(%(name)-10s %(filename)-10s: %(lineno)d): %(message)-30s",
    logging.WARN: "%(asctime)s %(levelname)-5s: (%(name)-10s %(filename)-10s: %(lineno)d): %(message)-30s",
-    logging.INFO: "%(message)-30s",
+    logging.INFO: _INFO_FORMAT,


@jacalata please check this, I'm not sure the right answer

Co-authored-by: bcantoni <58372+bcantoni@users.noreply.github.com>

Copilot

🔵 Needs a closer look

Unresolved moderate issues remain in localized error formatting, export content names, and logging behavior.

2 open findings

🧠 Review effort: Lite

jacalata and others added 6 commits July 21, 2026 18:44

fix: print version/help output directly instead of via logger.info

494c015

Avoids the ===== prefix being applied to the version/help display. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: remove spurious 'logging: INFO' printed on every command

0d6dc0a

The condition compared logging_level string 'INFO' to the integer logging.INFO (20), which was always True, causing the print to fire on every invocation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

fix: add 'Signing in...' message to match tabcmd 1 login output

ee42aa9

session.login string already existed; add logger.info call at the start of _sign_in() to surface it as a distinct step after connecting. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

jacalata requested a lite review from Copilot September 18, 2026 22:01

Copilot started reviewing on behalf of jacalata September 18, 2026 22:01 View session

Copilot AI reviewed Sep 18, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings September 20, 2026 02:32

Copilot started reviewing on behalf of jacalata September 20, 2026 02:33 View session

Copilot AI reviewed Sep 20, 2026

View reviewed changes

Copilot started work on behalf of bcantoni October 14, 2026 05:38 View session

Copilot AI lite review requested due to automatic review settings October 14, 2026 05:40

Copilot started reviewing on behalf of jacalata October 14, 2026 05:40 View session

Copilot finished work on behalf of bcantoni October 14, 2026 05:42

Copilot AI requested a review from bcantoni October 14, 2026 05:42

Copilot AI reviewed Oct 14, 2026

View reviewed changes

Copilot started work on behalf of bcantoni October 14, 2026 05:45 View session

Apply remaining changes

e9e6161

Co-authored-by: bcantoni <58372+bcantoni@users.noreply.github.com>

Copilot AI lite review requested due to automatic review settings October 14, 2026 05:46

Copilot finished work on behalf of bcantoni October 14, 2026 05:46

Copilot started reviewing on behalf of jacalata October 14, 2026 05:46 View session

Copilot AI reviewed Oct 14, 2026

View reviewed changes

Navigation Menu

Repository navigation

fix: correct and standardize tabcmd 2 output messages to match tabcmd 1 - #432

fix: correct and standardize tabcmd 2 output messages to match tabcmd 1#432
jacalata wants to merge 10 commits into
developmentfrom
jac/fix-output-messages

jacalata commented Jul 22, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

bcantoni commented Jul 25, 2026

Uh oh!

jacalata commented Jul 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

bcantoni commented Oct 14, 2026

Uh oh!

Copilot AI commented Oct 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

bcantoni Oct 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jacalata commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation

Behavior change

Test plan

Uh oh!

github-actions Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bcantoni commented Jul 25, 2026

Uh oh!

jacalata commented Jul 27, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

bcantoni commented Oct 14, 2026

Uh oh!

Copilot AI commented Oct 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

bcantoni Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🔵 Needs a closer look

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jacalata commented Jul 22, 2026 •

edited

Loading

github-actions Bot commented Jul 22, 2026 •

edited

Loading