fix: add workbook and view setter for custom view #1730
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes tableau#1729 Add setter methods for workbook and view properties.
jorwoods
force-pushed
the
jorwoods/custom_view_set_wb
branch
from
9a1de1e to
eb2df3f
Compare
Contributor
|
@jorwoods this looks great. Should we also consider updating test_custom_view.py to replace those direct access _owner and _workbook with the new way? (I'm not sure that's super valuable though because we still have the direct access needed for |
Contributor
Author
|
@bcantoni Makes sense to me to verify that the getters and setters work. I'll make the change. |
bcantoni
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1729
Add setter methods for workbook and view properties.