Skip to content

[AArch64] Pending IRQ is enqueued twice when maintenance retry finds no free LR #396

Description

@0xtiger5

Description

In the GICv3 virtual interrupt injection path, a pending interrupt can be
enqueued twice when it is retried from a maintenance interrupt and no List
Register (LR) is available.

The issue is present in the official v0.6 source:

  • Version: v0.6
  • Commit: e25fc10da62eef09e1dbd6ed8b15fb9a0dfcef59
  • File:
    src/device/irqchip/gicv3/mod.rs

Relevant code:

Note

The same queue ownership issue also exists in the GICv2 implementation in
v0.6.

When all GICH List Registers are occupied, inject_irq() already re-enqueues
the interrupt and returns false. The GICv2
handle_maintenace_interrupt() then enqueues the same interrupt again.

Relevant code:

The same single-owner rule for pending-queue insertion should therefore be
reviewed for both GICv3 and GICv2.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions