Conversation
Seal rewrite origin maps before publishing them so the fast path can no longer be retargeted by writable bitmap state at runtime. This moves the seccomp-filter handoff into sanitizer-free transfer helper and fail fast on the unsupported x64 ASAN trap/rewrite path instead of hanging after filter installation. This keeps guest transition deterministic on the validated hosts while preserving the existing seccomp path. Reject executable shared-file aliases in trap/rewrite mode, and reject PROT_EXEC promotion when the target range overlaps a shared writable file mapping. That closes the guest-visible JIT alias path exercised by the new regression probe. Add unit test for origin-map sealing plus guest rewrite regressions for the currently enforced JIT spray and alias boundaries. While touching these paths, clean up the pre-existing warning set by consuming checked I/O results, fixing the fault-handler identity check, and tightening linker segment flags. Change-Id: I7a520db9e08ed2b7d1ac9adf5fca1fa1930f0a17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seal rewrite origin maps before publishing them so the fast path can no longer be retargeted by writable bitmap state at runtime. This moves the seccomp-filter handoff into sanitizer-free transfer helper and fail fast on the unsupported x64 ASAN trap/rewrite path instead of hanging after filter installation. This keeps guest transition deterministic on the validated hosts while preserving the existing seccomp path.
Reject executable shared-file aliases in trap/rewrite mode, and reject PROT_EXEC promotion when the target range overlaps a shared writable file mapping. That closes the guest-visible JIT alias path exercised by the new regression probe.
Add unit test for origin-map sealing plus guest rewrite regressions for the currently enforced JIT spray and alias boundaries. While touching these paths, clean up the pre-existing warning set by consuming checked I/O results, fixing the fault-handler identity check, and tightening linker segment flags.
Change-Id: I7a520db9e08ed2b7d1ac9adf5fca1fa1930f0a17
Summary by cubic
Hardens trap/rewrite execution to close a JIT alias path and make guest launch deterministic. Seals rewrite origin maps and fails fast on unsupported x64 ASAN builds.
New Features
Bug Fixes
-Wl,-z,noexecstackand-Wl,-z,separate-code; fix fault-handler identity check; consume I/O return values to clear warnings.Written for commit 0000dab. Summary will update on new commits.