Relax commit message check for URLs - #385
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
The body width rule rejects every line over 72 characters, including one that holds only a link, and a URL cannot be wrapped. Accept a line when everything past column 72 is one word containing an http or https URL. Other schemes and prose after the link are still rejected.
Rule 6 in CONTRIBUTING.md reads as a flat 72-character limit, while the commit-msg hook lets a line run past it when everything beyond column 72 is one word containing an http or https URL. State that exception below the rule list.
henrybear327
force-pushed
the
commit-msg-url
branch
from
September 16, 2026 09:39
ec1463b to
17c71a6
Compare
Contributor
|
Thank @henrybear327 for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 32d7227, a strict max 72-char per line check is introduced, which will block the commit which contains URL references.
Summary by cubic
The commit-message hook previously rejected every body line longer than 72 characters. It now permits overflow only when everything after column 72 belongs to one unbroken word containing an http or https URL; prose before or after that URL remains subject to the limit.
Bug Fixes
CONTRIBUTING.mdand adds coverage for valid URL placements and invalid overlong lines.Written for commit 17c71a6. Summary will update on new commits.