Conversation
Every main push since the linkage guard landed fails it: Xcode 16.4 on the macos-15 runner drops WebRTC's NSString category even with -ObjC, while a 26 linker keeps it. Build with Xcode 26.3 through DEVELOPER_DIR and pin MACOSX_DEPLOYMENT_TARGET to 11.0, since cc would otherwise target the 26 SDK, so the release still loads on macOS 15. The verify step now also checks the linker, the minimum OS and a launch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every main push since the linkage guard landed fails it: Xcode 16.4 on the macos-15 runner drops WebRTC's NSString category even with -ObjC, while a 26 linker keeps it. Build with Xcode 26.3 through DEVELOPER_DIR and pin MACOSX_DEPLOYMENT_TARGET to 11.0, since cc would otherwise target the 26 SDK, so the release still loads on macOS 15. The verify step now also checks the linker, the minimum OS and a launch.
Summary by cubic
The macOS arm64 release build now uses Xcode 26.3 through
DEVELOPER_DIRinstead of the runner’s Xcode 16.4, which dropped WebRTC’sNSStringcategory despite-ObjC. It pinsMACOSX_DEPLOYMENT_TARGETto macOS 11 so binaries linked with the newer SDK still run on macOS 15.Verification
NSStringcategory remains in the binary.Written for commit 93bba87. Summary will update on new commits.