Keep selected editor text visible - #49
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ColtenOuO
reviewed
Sep 16, 2026
ColtenOuO
left a comment
ColtenOuO
left a comment
Collaborator
There was a problem hiding this comment.
Just a minor suggestion, non-blocking for this PR.
The textarea leaves its glyphs transparent so the syntax-highlight layer can paint them. Its selection background covers that layer, which made selected code unreadable without a separate foreground color.
moon-jam
force-pushed
the
fix-editor-selection-text-visable
branch
from
September 16, 2026 14:03
d9221e4 to
efbb220
Compare
Contributor
|
Thank @moon-jam for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Selected text in the interview editor was unable to read because the textarea keeps its text transparent while the selection background covers the syntax-highlight layer underneath.
Set a foreground color for selected text so it remains visible while preserving the existing overlay-based syntax highlighting.
Sample
Before:
After:
Summary by cubic
Fixes selected text in the interview editor being unreadable by adding a foreground color to
#editor::selection. The textarea glyphs stay transparent for the syntax-highlight overlay, but the selection background was covering that layer; now selected text uses the ink color and remains visible.Written for commit efbb220. Summary will update on new commits.