Keep grounding choices when the other file loads - #39
Merged
Merged
Conversation
jserv
reviewed
Sep 14, 2026
jserv
reviewed
Sep 14, 2026
jserv
requested changes
Sep 14, 2026
jserv
left a comment
Contributor
There was a problem hiding this comment.
Rebase latest main branch and resolve conflicts.
Every upload rebuilt all three snippet lists from scratch, so loading a resume unchecked JD requirements the candidate had already picked, and nothing on the page said so. Only the groups a file replaces lose their selection now, since those indexes point into a list that no longer exists.
ColtenOuO
force-pushed
the
fix-grounding-selection
branch
from
September 14, 2026 09:34
65b6fc7 to
f328c7b
Compare
Contributor
Author
|
Thanks for reviewing! Addressed all feedback from the inline comments and resolved merge conflicts. |
Contributor
|
Thank @ColtenOuO for contributing! |
This was referenced Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sumarry
In the lobby's document grounding section, every JD or resume upload rebuilt all three snippet lists from scratch. Checking a few JD requirements and then uploading a resume silently unchecked them, and the same happened in reverse.
Sample
Upload and select checkboxes
After uploading the resume
Fix
Before a file is parsed, the current selection is read and only the groups that file replaces are dropped (
requirementsfor a JD,skillsandanchorsfor a resume), since those indexes point into a list that no longer exists. The rest is restored when the lists are re-rendered.web/document-grounding.js: addretainedSelection(selected, kind)web/app.js: extractcheckedGrounding()(shared with the Start handler) and pass the retained selection torenderGroundingChoicesSummary by cubic
Fixes the lobby's document grounding so uploading a resume no longer clears JD requirement checkboxes, and vice versa.
checkedGrounding()so the Start handler and file loading share the same selection logic.Written for commit f328c7b. Summary will update on new commits.