Skip to content

refactor(wiki): retire legacy JSON cache - #767

Merged
fishmingyu merged 1 commit into
mainfrom
refactor/retire-wiki-json-cache-v1
Sep 5, 2026
Merged

refactor(wiki): retire legacy JSON cache#767
fishmingyu merged 1 commit into
mainfrom
refactor/retire-wiki-json-cache-v1

Conversation

@fishmingyu

Copy link
Copy Markdown
Member

Summary

Retire the one-release AgentWiki JSON compatibility path after the v0.2.3 migration window. WikiStore is now the only persistence boundary; an AgentWiki without an injected store is memory-only.

Closes #749.

Changes

  • Remove legacy agentwiki_*.json discovery, parsing, adoption, writing, file locks, and provenance markers.
  • Make Wiki cache quality and coverage audits store-only; bump the coverage report to schema v2 with database-only storage accounting.
  • Preserve SQLite entry identities, schema, existing rows, the WikiStore protocol, and the exact eight-symbol codenib.storage facade.
  • Update Web, CLI, prewarm, benchmark, tests, operating docs, and durable roadmaps for the retired path.

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update
  • Refactoring
  • Performance improvement
  • Tests

Testing

  • Tests pass locally

  • Added new tests for the changes

  • pytest -q test/wiki/test_agent_wiki.py test/wiki/test_cache_audit.py test/wiki/test_quality.py test/web/test_app_runtime.py --tb=short (251 passed)

  • pytest -q test/wiki/test_store_contract.py test/wiki/test_sqlite_store.py test/test_storage_api.py test/wiki/test_prewarm.py --tb=short (68 passed)

  • pytest -q test/scripts/test_benchmark_demo_wiki.py test/test_cli.py --tb=short (90 passed)

  • Full local unit tier excluding test/sandbox/test_docker.py (6876 passed, 35 skipped, 190 deselected); the unfiltered run reached 3395 passed before the environment-only /usr/bin/docker absence stopped it.

  • Black, isort (--profile black), flake8, compileall, and git diff --check pass for the changed surface.

Checklist

  • My code follows the project's style guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

@github-actions github-actions Bot added type/docs Documentation type/test Test-related labels Sep 5, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 5, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-05T20:11:01.123198Z be0b86f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fishmingyu
fishmingyu force-pushed the refactor/retire-wiki-json-cache-v1 branch from be0b86f to 727a007 Compare September 5, 2026 20:07
Remove AgentWiki JSON read-through, adoption, writes, locks, and legacy audit accounting after the v0.2.3 migration window. Keep the WikiStore API, SQLite schema, persisted rows, and public storage facade unchanged.

Verify store-only persistence, old SQLite envelope readability, audit schema v2, production composition roots, and the local unit tier.
@fishmingyu
fishmingyu force-pushed the refactor/retire-wiki-json-cache-v1 branch from 727a007 to 07464a5 Compare September 5, 2026 20:11
@fishmingyu
fishmingyu merged commit 640f85f into main Sep 5, 2026
26 checks passed
@fishmingyu
fishmingyu deleted the refactor/retire-wiki-json-cache-v1 branch September 5, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type/docs Documentation type/test Test-related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Retire Wiki Store legacy JSON read-through

1 participant