refactor(wiki): retire legacy JSON cache - #767
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fishmingyu
force-pushed
the
refactor/retire-wiki-json-cache-v1
branch
from
September 5, 2026 20:07
be0b86f to
727a007
Compare
Remove AgentWiki JSON read-through, adoption, writes, locks, and legacy audit accounting after the v0.2.3 migration window. Keep the WikiStore API, SQLite schema, persisted rows, and public storage facade unchanged. Verify store-only persistence, old SQLite envelope readability, audit schema v2, production composition roots, and the local unit tier.
fishmingyu
force-pushed
the
refactor/retire-wiki-json-cache-v1
branch
from
September 5, 2026 20:11
727a007 to
07464a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Retire the one-release AgentWiki JSON compatibility path after the v0.2.3 migration window.
WikiStoreis now the only persistence boundary; an AgentWiki without an injected store is memory-only.Closes #749.
Changes
agentwiki_*.jsondiscovery, parsing, adoption, writing, file locks, and provenance markers.WikiStoreprotocol, and the exact eight-symbolcodenib.storagefacade.Type of Change
Testing
Tests pass locally
Added new tests for the changes
pytest -q test/wiki/test_agent_wiki.py test/wiki/test_cache_audit.py test/wiki/test_quality.py test/web/test_app_runtime.py --tb=short(251 passed)pytest -q test/wiki/test_store_contract.py test/wiki/test_sqlite_store.py test/test_storage_api.py test/wiki/test_prewarm.py --tb=short(68 passed)pytest -q test/scripts/test_benchmark_demo_wiki.py test/test_cli.py --tb=short(90 passed)Full local unit tier excluding
test/sandbox/test_docker.py(6876 passed, 35 skipped, 190 deselected); the unfiltered run reached 3395 passed before the environment-only/usr/bin/dockerabsence stopped it.Black, isort (
--profile black), flake8, compileall, andgit diff --checkpass for the changed surface.Checklist