Skip to content

Conversation

@ben-kaufman
Copy link
Contributor

@ben-kaufman ben-kaufman commented Jan 15, 2026

Fixes missing activities when migrating RN app which had activities of unsupported address types.

Testing:

Could use this seed which has example recceving to each address type this making 2 send txs:

amazing shy syrup aspect mistake hungry about sail predict rifle lawsuit supply
  • Import this seed into the RN app, or create a new wallet and generated activity for different address types.
  • Run the native app to trigger migration and make sure all activities pass correctly.

Note

The RN app doesn't back up on-chain activities on the remote backup, which means if user recovers using mnemonic and RN backup activities from unsupported address types won't show up.

@claude

This comment has been minimized.

@ben-kaufman ben-kaufman force-pushed the fix/migrate-unsupported-addresses-activities branch from 5c68064 to 1da9cae Compare January 15, 2026 02:57
@claude

This comment has been minimized.

@ben-kaufman ben-kaufman force-pushed the fix/migrate-unsupported-addresses-activities branch from 6565eba to ee7c812 Compare January 15, 2026 03:12
@claude
Copy link

claude bot commented Jan 15, 2026

Code review

Found 1 issue related to CLAUDE.md compliance:

PR Description Format

The PR description does not follow the required template structure defined in .github/pull_request_template.md.

CLAUDE.md rule (line 206): "ALWAYS use template in .github/pull_request_template.md for PR descriptions"

Current description structure:

  • Unstructured description at the top
  • "Testing:" section (instead of required headers)

Required template structure:

  • ### Description
  • ### Preview
  • ### QA Notes

Please update the PR description to use the template headers.


Code changes: No bugs or CLAUDE.md violations found in the code itself. The migration logic and value preservation approach look good.

@jvsena42
Copy link
Member

utAck, testing...

Copy link
Collaborator

@ovitrif ovitrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

sweep.mp4

@ovitrif ovitrif merged commit 528b028 into master Jan 15, 2026
14 checks passed
@ovitrif ovitrif deleted the fix/migrate-unsupported-addresses-activities branch January 15, 2026 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants