Skip to content

Task(1046238): Fix for the ESM in the SfPullToRefresh #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PaulAndersonS merged 1 commit into from
Sep 16, 2026
Merged

Task(1046238): Fix for the ESM in the SfPullToRefresh #421

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 27 additions & 17 deletions maui/src/PullToRefresh/SfPullToRefresh.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ public SfPullToRefresh()
Children.Add(_progressCircleView);
ClipToBounds = true;
ThemeElement.InitializeThemeResources(this, "SfPullToRefreshTheme");

// Ensures the refreshing animation starts if IsRefreshing was set via global styles.
if (this.IsRefreshing && !this.ActualIsRefreshing)
{
Expand Down Expand Up @@ -1327,6 +1327,16 @@ internal bool CancelPulling()
RaisePullingCancelled();
return true;
}

/// <summary>
/// Gets and Updates the previousBounds.
/// </summary>
/// <returns>Returns the rect based on Previous height passed in arrange pass to pull to refresh.</returns>
internal Rect GetAndUpdateWithPreviousBounds()
{
return new Rect(this.Bounds.X, this.Bounds.Y, this.Bounds.Width, this.Bounds.Height);
}

#endregion

#region Private Methods
Expand Down Expand Up @@ -1782,15 +1792,16 @@ void RaiseRefreshedEvent(object sender)

// Included condition for battery saver logic for android platform.
HideSfProgressCircleView();
var canAnimate = TransitionMode == PullToRefreshTransitionType.Push;
#if ANDROID
canAnimate = Battery.Default.EnergySaverStatus is not EnergySaverStatus.On;
#endif
ArrangePullableContent(GetBounds(), canAnimate);
var canAnimate = this.TransitionMode == PullToRefreshTransitionType.Push && !(DeviceInfo.Platform == DevicePlatform.Android && Battery.Default.EnergySaverStatus == EnergySaverStatus.On);
if (this.TransitionMode == PullToRefreshTransitionType.Push)
{
this.ArrangePullableContent(this.GetAndUpdateWithPreviousBounds(), canAnimate);
}

(this as IView).InvalidateMeasure();
if (Refreshed is not null)
if (this.Refreshed != null)
{
Refreshed(this, EventArgs.Empty);
this.Refreshed(this, EventArgs.Empty);
}
}

Expand Down Expand Up @@ -1833,18 +1844,17 @@ async void Rotate()
}
catch
{
#if WINDOWS
if (DeviceInfo.Platform != DevicePlatform.Android && DeviceInfo.Platform != DevicePlatform.iOS)
{
#if NET10_0_OR_GREATER
await PullableContent.TranslateToAsync(0, RefreshViewHeight * 2, 300);
await ProgressCircleView.TranslateToAsync((Width / 2) - (RefreshViewWidth / 2), RefreshViewHeight / 1.5, 250);
await this.PullableContent.TranslateToAsync(0, this.RefreshViewHeight * 2, 300);
await this.ProgressCircleView.TranslateToAsync((this.Width / 2) - (this.RefreshViewWidth / 2), this.RefreshViewHeight / 1.5, 250);
#else
const int contentLength = 300;
const int circleViewLength = 250;
await PullableContent.LayoutTo(new Rect(0, RefreshViewHeight * 2, Width, Height - (RefreshViewHeight * 2)), contentLength).ConfigureAwait(true);
await ProgressCircleView.LayoutTo(new Rect((Width / 2) - (RefreshViewWidth / 2), RefreshViewHeight / 1.5, RefreshViewWidth, RefreshViewHeight), circleViewLength).ConfigureAwait(true);
#endif
HideSfProgressCircleView();
await this.PullableContent.LayoutTo(new Rect(0, this.RefreshViewHeight * 2, this.Width, this.Height - (this.RefreshViewHeight * 2)), 300).ConfigureAwait(true);
await this.ProgressCircleView.LayoutTo(new Rect((this.Width / 2) - (this.RefreshViewWidth / 2), this.RefreshViewHeight / 1.5, this.RefreshViewWidth, this.RefreshViewHeight), 250).ConfigureAwait(true);
#endif
this.HideSfProgressCircleView();
}
}

_isCircleRotating = false;
Expand Down