Skip to content

fix(evidence): expose bounded reviewer timeouts#8726

Open
scarmani wants to merge 1 commit into
mainfrom
codex/collect-evidence-timeout-followup-20260630
Open

fix(evidence): expose bounded reviewer timeouts#8726
scarmani wants to merge 1 commit into
mainfrom
codex/collect-evidence-timeout-followup-20260630

Conversation

@scarmani

@scarmani scarmani commented Jun 30, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add explicit --reviewer-timeout and --overall-timeout controls to review-queue collect-evidence and scripts/collect_quorum_evidence.py.
  • Fail closed when the overall reviewer deadline expires, with JSON diagnostics for orchestration_timeout, timed_out_families, and overall_timeout_seconds.
  • Apply per-reviewer timeout overrides to Claude, Codex/OpenAI, API reviewers, Grok Build, and Antigravity/Gemini CLI paths for only the current invocation.

Validation

  • Current-main baseline: origin/main = 3d2af8d2c10f981d7ddd37cba6cc3f96af1afaba; python3 -m aragora.cli.main review-queue collect-evidence --help does not expose the timeout flags there.
  • Exact PR head: 1bf591bdb41193bc9d12a1908583f3f97ce264ec; both python3 -m aragora.cli.main review-queue collect-evidence --help and python3 scripts/collect_quorum_evidence.py --help expose --reviewer-timeout and --overall-timeout.
  • PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 timeout 300 /Users/armand/.pyenv/versions/3.11.11/bin/python -m pytest tests/swarm/test_quorum_evidence.py tests/cli/commands/test_review_queue.py -q - 476 passed.
  • timeout 240 pre-commit run --files scripts/collect_quorum_evidence.py aragora/swarm/quorum_evidence.py aragora/cli/commands/review_queue.py aragora/cli/parser.py tests/swarm/test_quorum_evidence.py tests/cli/commands/test_review_queue.py - passed.
  • After marking ready for review, required non-quorum checks are green (lint, typecheck, Generate & Validate, TypeScript SDK Type Check, sdk-parity). aragora-merge-quorum fails closed as expected because this is Tier 4 merge/evidence-authority code and still needs current-head model quorum plus human preapproval/settlement before merge.

Dogfood on blocked PR evidence flow

Dogfood note

@scarmani scarmani marked this pull request as ready for review June 30, 2026 21:51
@scarmani scarmani requested a review from an0mium as a code owner June 30, 2026 21:51
@github-actions

Copy link
Copy Markdown
Contributor

Aragora Code Review

Advisory-only review. No issues found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant