fix(evidence): expose bounded reviewer timeouts#8726
Open
scarmani wants to merge 1 commit into
Open
Conversation
Contributor
Aragora Code ReviewAdvisory-only review. No issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--reviewer-timeoutand--overall-timeoutcontrols toreview-queue collect-evidenceandscripts/collect_quorum_evidence.py.orchestration_timeout,timed_out_families, andoverall_timeout_seconds.Validation
origin/main=3d2af8d2c10f981d7ddd37cba6cc3f96af1afaba;python3 -m aragora.cli.main review-queue collect-evidence --helpdoes not expose the timeout flags there.1bf591bdb41193bc9d12a1908583f3f97ce264ec; bothpython3 -m aragora.cli.main review-queue collect-evidence --helpandpython3 scripts/collect_quorum_evidence.py --helpexpose--reviewer-timeoutand--overall-timeout.PYTEST_DISABLE_PLUGIN_AUTOLOAD=1 timeout 300 /Users/armand/.pyenv/versions/3.11.11/bin/python -m pytest tests/swarm/test_quorum_evidence.py tests/cli/commands/test_review_queue.py -q- 476 passed.timeout 240 pre-commit run --files scripts/collect_quorum_evidence.py aragora/swarm/quorum_evidence.py aragora/cli/commands/review_queue.py aragora/cli/parser.py tests/swarm/test_quorum_evidence.py tests/cli/commands/test_review_queue.py- passed.lint,typecheck,Generate & Validate,TypeScript SDK Type Check,sdk-parity).aragora-merge-quorumfails closed as expected because this is Tier 4 merge/evidence-authority code and still needs current-head model quorum plus human preapproval/settlement before merge.Dogfood on blocked PR evidence flow
136f3002013c7026c74f68d1892c52718e33b23b: Tier 1, mergeable, required checks green exceptaragora-merge-quorum, blocker is missing model quorum/focused dogfood.--reviewer-timeout 1 --overall-timeout 0.01 --json: returnedaction=prepare,orchestration_timeout=true,timed_out_families=[claude,grok],overall_timeout_seconds=0.01, zero evidence items, and no posted families.python3 -m aragora.cli.main review-queue collect-evidence --repo synaptent/aragora --pr 8389 --reviewers claude grok --reviewer-timeout 45 --overall-timeout 60 --jsonreturned one countable Grok PASS (would_count=true) while Claude exceeded the 60s orchestration deadline. The collector still failed closed withaction=prepare,orchestration_timeout=true,timed_out_families=[claude],has_supportive_quorum=false, and no posts.7aacade51697f601c4e595325940143505ded01d: PR is closed, and the packet correctly reportsnot_ready_for_settlement; no reviewer evidence was collected for the closed PR.Dogfood note