Skip to content

fix(review-queue): bound collect-evidence timeouts#8472

Open
scarmani wants to merge 9 commits into
mainfrom
codex/collect-evidence-timeouts-20260616
Open

fix(review-queue): bound collect-evidence timeouts#8472
scarmani wants to merge 9 commits into
mainfrom
codex/collect-evidence-timeouts-20260616

Conversation

@scarmani

Copy link
Copy Markdown
Collaborator

Summary

  • add reviewer/overall timeout controls to collect-evidence CLI surfaces
  • fail closed when reviewer orchestration times out, recording per-family failures and no partial quorum posts
  • preserve evidence-lint-before-post and tier-gated posting behavior

Validation

  • python3 -m pytest tests/swarm/test_quorum_evidence.py tests/cli/commands/test_review_queue.py
  • pre-commit run --files scripts/collect_quorum_evidence.py aragora/swarm/quorum_evidence.py aragora/cli/commands/review_queue.py aragora/cli/parser.py tests/swarm/test_quorum_evidence.py tests/cli/commands/test_review_queue.py

Draft only: do not retry #8457 evidence or merge in this cycle.

@scarmani

Copy link
Copy Markdown
Collaborator Author

Grok independent model review

Reviewer: grok (xai) — independent adversarial model review via the Aragora Grok reviewer, grounded on the exact PR head.
Head: ff27386 (ff27386), committed 2026-06-16T15:40:13Z.
PR: #8472.
Model family: grok

Verdict: PASS

  • No blocking issues identified. Logic is defensive (fail-closed on timeout/invalid fork, validated positive floats, env restore, process group signals with fallbacks). Tests cover key paths (start failures, queue lag, mixed slow reviewers). Dupe parser wiring and thread/process switch are intentional for CLI/script parity.

dogfood: yes

@scarmani

Copy link
Copy Markdown
Collaborator Author

OpenAI independent model review

Reviewer: openai (openai) — independent adversarial model review via Codex CLI OpenAI harness, grounded on the exact PR head.
Head: ff27386 (ff27386), committed 2026-06-16T15:40:13Z.
PR: #8472.
Model family: openai

Verdict: PASS

  • No blocking issues found in the reviewed diff.
  • [P3] aragora/swarm/quorum_evidence.py:1104 comment says non-fork platforms get a thread fallback, but implementation later fails all reviewers closed when --overall-timeout is set and fork is unavailable. The behavior is tested, so this is a documentation/comment mismatch rather than a correctness blocker.

dogfood: yes

@scarmani scarmani marked this pull request as ready for review June 16, 2026 15:50
@scarmani scarmani requested a review from an0mium as a code owner June 16, 2026 15:50
@github-actions

Copy link
Copy Markdown
Contributor

Aragora Code Review

Advisory-only review. No issues found.

Co-authored-by: codex[bot] <codex[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant