fix(ci): deploy-secure aws: command not found on macOS runners#680
Closed
an0mium wants to merge 1 commit into
Closed
fix(ci): deploy-secure aws: command not found on macOS runners#680an0mium wants to merge 1 commit into
an0mium wants to merge 1 commit into
Conversation
…ecure
When /usr/local/bin/aws is absent and pip3 installs awscli, the binary
lands in pip's scripts directory (e.g. sysconfig.get_path('scripts')),
which is not in PATH. The next step then fails with 'aws: command not
found' (exit 127).
Fix: after pip3 install, resolve the scripts dir via sysconfig and
append it to GITHUB_PATH. Also add /opt/homebrew/bin check for macOS
Homebrew installs, and short-circuit if aws is already in PATH.
Applies to all three Fix AWS CLI path steps (staging, production, DR).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by current main. The branch is stale, remains DIRTY against main, and its remaining net diff would overwrite the newer deploy-secure fix already landed on main (currently at bb2e577 and later). Closing to avoid reintroducing regressions. |
auto-merge was automatically disabled
March 6, 2026 08:25
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All 5 recent
deploy-secure.ymlruns fail at Get staging instance IDs with:The previous fix (PR #657) added a
Fix AWS CLI pathstep that correctly handles the case where/usr/local/bin/awsexists — but the else branch only runspip3 install awscli --quietwithout updating$GITHUB_PATH. Soawslands in pip's scripts directory (e.g.~/Library/Python/3.x/bin/on the macOS Hetzner runner) which is never added to PATH.Fix
Updated all three
Fix AWS CLI pathsteps (staging, production, DR):/usr/local/bin/aws→ add to GITHUB_PATH (existing)/opt/homebrew/bin/aws→ add to GITHUB_PATH (new: macOS Homebrew)command -v aws→ already in PATH, no-op (new: short-circuit)pip3 install awscli --quiet+ resolve scripts dir viasysconfig.get_path('scripts')→ add to GITHUB_PATH (bug fix: was missing the PATH update)Test plan
deploy-secure.ymlandGet staging instance IDsstep passes🤖 Generated with Claude Code