Repository navigation
[Mate] Resolve MATE_DEBUG_LOG_FILE against the project root and accept absolute paths - #2553
Merged
chr-hertel merged 1 commit intoSep 22, 2026
Conversation
…t absolute paths The runtime logger prefixed the configured log file with the project root unconditionally, so an absolute MATE_DEBUG_LOG_FILE ended up below the project. The build-time logger used the raw value instead and wrote relative to the working directory, so one run could log into two files. The container factory now anchors a relative path at the project root once, keeps an absolute path as it is, and both loggers read the same parameter.
Collaborator
|
Hey! To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done? Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review. Cheers! Carsonbot |
wachterjohannes
marked this pull request as ready for review
September 22, 2026 20:28
wachterjohannes
requested review from
Nyholm,
OskarStark and
chr-hertel
as code owners
September 22, 2026 20:28
carsonbot
added
Bug
chr-hertel
approved these changes
Sep 22, 2026
Member
|
Thank you @wachterjohannes. |
chr-hertel
added a commit
that referenced
this pull request
Sep 22, 2026
…ing-started page and reference pages (wachterjohannes) This PR was squashed before being merged into the main branch. Discussion ---------- [Mate][Docs] Split the component docs into a getting-started page and reference pages | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | Docs? | yes | Issues | | License | MIT `mate.rst` mixed onboarding with the extension, skills and command reference. The interpreter choice was explained twice with contradicting details, the extension toggle five times, and troubleshooting was spread over four pages. The index is now the getting-started page. New pages `mate/extensions.rst`, `mate/skills.rst` and `mate/commands.rst` hold the reference, and every topic has one home. The Symfony and Monolog packages are called extensions throughout, matching their package names, and community extensions point to MatesOfMate and awesome-mate. The pages also cover what the code offers but the docs missed: the `untrusted_data` envelope, all `symfony-profiler-list` filters, all eight collector formatters, undocumented command options, env file loading, and what `mate init` does without interaction. Depends on #2553 and #2554: the text describes `MATE_DEBUG_LOG_FILE` and `mate.env_file` as they behave with those two fixes. Commits ------- ff28aa3 [Mate][Docs] Split the component docs into a getting-started page and reference pages
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The runtime logger always prefixed
MATE_DEBUG_LOG_FILEwith the project root, so an absolute path like/var/log/mate/debug.log(the example in the docs) ended up below the project. The build-time logger used the raw value and wrote relative to the working directory, so one run could log into two files.The container factory now anchors a relative path at the project root once and keeps an absolute path as it is. Both loggers read the same
mate.debug_log_fileparameter, and an override inmate/config.phpis resolved the same way.