Repository navigation
[Platform][VertexAi] Normalize nullable fields in structured output schema - #2398
Merged
Merged
Conversation
ousamabenyounes
requested review from
OskarStark and
chr-hertel
as code owners
August 11, 2026 22:25
ousamabenyounes
force-pushed
the
fix/issue-1999
branch
from
August 20, 2026 14:21
eab49f2 to
8ecf759
Compare
chr-hertel
reviewed
Sep 22, 2026
chr-hertel
approved these changes
Sep 22, 2026
chr-hertel
left a comment
Member
There was a problem hiding this comment.
Reproduced issue and confirmed as fix!
chr-hertel
reviewed
Sep 22, 2026
chr-hertel
force-pushed
the
fix/issue-1999
branch
from
September 22, 2026 22:08
60c310e to
b420192
Compare
Member
|
Thank you @ousamabenyounes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Using structured output with the Vertex/Gemini bridge throws as soon as a DTO property is nullable:
The JSON Schema factory represents a nullable field with an array-style type (
"type": ["string", "null"]). VertexAI's OpenAPI-flavored schema parser does not accept an array there — it requires a singletypeplus"nullable": true.Contract\ToolNormalizeralready performed this conversion for tool parameter schemas, but the structured-outputresponseSchemainGemini\ModelClientwas assigned straight from theresponse_formatpayload without any normalization, so nullable fields broke.Fix
nullable: trueconversion (and theadditionalPropertiesstripping) fromToolNormalizerinto a sharedSchemaNormalizer.ToolNormalizernow delegates to it (identical behavior, no duplicated logic).Gemini\ModelClientruns the structured-outputresponseSchemathrough the same normalizer, so tool and response schemas stay in sync.Test verification (RED → GREEN)
New test
testItNormalizesNullableFieldsInStructuredOutputResponseSchemaasserts the wireresponseSchemahas a singletype+nullable: true(top-level and nesteditems) and noadditionalProperties.On the unmodified branch (RED):
With the fix (GREEN), the whole VertexAi bridge suite (including the existing ToolNormalizer nullable tests, proving behavior parity after the extraction):
PHPStan and PHP-CS-Fixer are clean on the changed files.