Skip to content

allow any true value for sort arg of s_musig_pubkey_agg #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scgbckbone wants to merge 1 commit into
base: master
Choose a base branch
from
Open

allow any true value for sort arg of s_musig_pubkey_agg #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ngu/k1.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -705,7 +705,7 @@ STATIC mp_obj_t s_musig_pubkey_agg(size_t n_args, const mp_obj_t *pos_args, mp_m

int ok;
// default is to sort the pubkeys - so aggregate key is always the same from same set of keys regardless of order
bool sort_pubkeys = (args[2].u_obj == mp_const_true);
bool sort_pubkeys = mp_obj_is_true(args[2].u_obj);
if (sort_pubkeys){
ok = secp256k1_ec_pubkey_sort(secp256k1_context_static, pks, len_pubkeys);
if (!ok){
Expand Down Expand Up @@ -886,10 +886,10 @@ STATIC mp_obj_t s_musig_nonce_gen(size_t n_args, const mp_obj_t *pos_args, mp_ma
}

// new nonce produced by this function
// musig pubnonce
// musig secnonce
mp_obj_musig_secnonce_t *sn = m_new_obj(mp_obj_musig_secnonce_t);
sn->base.type = &s_musig_secnonce_type;
// musig secnonce
// musig pubnonce
mp_obj_musig_pubnonce_t *pn = m_new_obj(mp_obj_musig_pubnonce_t);
pn->base.type = &s_musig_pubnonce_type;

Expand Down