fix(forwarding): restore hold-to-stop for scanning profiles - #177
Merged
Merged
Conversation
Removing it in #173 left switch users no way to end a session from a switch. A release at or past the Forwarding hold-to-stop stops forwarding without an actionable release again; shorter holds still deliver their release so the PC can run hold actions. The idle stop stays off for scanning, and cancelled or replaced presses keep their sync-based handling. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #176
Summary
#173 made scanning profiles ignore the Forwarding hold-to-stop so the PC could run hold actions past five seconds, but that removed the only switch-driven way to end a session: the PC's emergency hold resets the scan and keeps the session. The hold-to-stop applies to scanning profiles again. A release at or past the configured 3, 5 or 8 seconds stops forwarding and sends
switch.session.stopwithout an actionable release, as before #173. Shorter holds still deliver their release so the PC can offer hold actions inside that window. The idle stop stays off for scanning, and cancelled or replaced presses keep the sync-based handling from #173.The setting description, protocol doc and smoke-test doc describe the behaviour. Companion PC docs PR: switchifyapp/switchify-pc#767.
Validation
npm run validateon Node 24: lint, TypeScript, 594 tests across 66 suites, 21 of 21 Expo Doctor checksA new test holds for just under the limit and sees the release delivered with the session still active, then holds past it and sees the session stop with no
upedge. Physical Android to PC validation remains outstanding.