Repository navigation
Lay out the Account page like the rest of the app - #998
Merged
Merged
Conversation
Rebuild the Account page from the Home page's status band and grouped rows: a band with the signed-in email (or Sign in / Check your email while signing in) and Sign out; rows for Settings sync and What syncs; and Delete account in its own card with a danger-styled inline confirmation. Rows whose choice is two buttons put them under the text. Behaviour, focus handling and announcements are unchanged. Refs #997 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Address review on the Account page layout: - A failed Sign out shows its error in the band beside the button, and a failed delete inside the confirmation; once off the signed-in screen the error joins the form, so it is never off screen or orphaned. - The sync status becomes a live region only once it is known, so opening the page does not announce a placeholder change. - Single-row cards are plain lists rather than regions repeating their heading. - StatusIcon is shared from ui/controls with Home. - The keychain band says "Can't read your saved sign-in" (locked or unavailable), and What syncs lists setup progress and diagnostics sharing as staying on each computer. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Keep account now clears a failed delete's error so it cannot resurface in the sign-in form later. Tests cover the keychain band title and that the sync status is not a live region until it is known. Remove a stray blank line in App.tsx. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #997
What
The Account page is rebuilt from the components Home already uses (
connection-band status-hero,status-listrows,status-iconwith tick or mark badges), so it no longer reads as plain text with unevenly stacked buttons.StatusIconis now shared fromui/controlswith Home.Validation
npm run lint,npm test(289 passed, including where errors appear) andnpm run build. Tests are updated for the new wording, the confirmation lives in its own row, and the email is now the band heading.🤖 Generated with Claude Code