Repository navigation
Upgrade vitest to clear new dependency audit advisories - #996
Merged
Merged
Conversation
Newly published advisories in vitest/@vitest/mocker, tinypool and source-map-js fail the required Dependency audit check. Upgrade vitest to 5.x and refresh source-map-js in the lockfile; npm audit now reports no vulnerabilities and all tests pass unchanged. Fixes #995 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
vitest 5 lists an optional third-party peer package whose name contains the retired word, so the lockfile now matches the check even though nothing of ours uses it. Lockfiles hold only third-party package names; exclude it the same way src-tauri/Cargo.lock already is. Refs #995 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #995
What
Tooling only: upgrades
vitestfrom 3.x to 5.x, the fix for the vitest,@vitest/mockerandtinypooladvisories.npm audit fixrefreshessource-map-jsin the lockfile. Nothing shipped in the app changes.No config changes: the existing
vitestconfig and tests run unchanged.CI identity check:
.github/workflows/ci.yml's retired-identity grep now also excludespackage-lock.json, as it already doessrc-tauri/Cargo.lock. Vitest 5 lists an optional third-party peer package (@vitest/browser-…) whose name contains the retired word. It isn't installed or used; lockfiles hold only third-party package names, so excluding the file doesn't weaken the check for our own code.Validation
npm audit: found 0 vulnerabilities, where before there were 2 critical, 1 high and 1 moderate.npm run lint,npm test(279 passed, all 13 files) andnpm run buildall pass.🤖 Generated with Claude Code