Repository navigation
Give the account its own page in place of the sidebar version - #993
Merged
Merged
Conversation
The sidebar footer now shows the settings sync account: "Account" with the signed-in email (shortened with an ellipsis), or "Sign in" when signed out. Selecting it opens Settings on the Account section with focus there, the way update notices open the Updates section. It follows account changes live. Builds without accounts keep showing the version, which also remains in Settings > Updates and on Home. Refs #992 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Address review on the sidebar account entry: - The sidebar reads the account with a new read-only get_account_status command, so loading it never re-reads (and never prompts for) the keychain; only opening the Account tab does. - Opening the Account tab broadcasts the account, so a sign-in recovered from a locked keychain reaches the sidebar too. - While the keychain is locked the entry says Account, not Sign in. - The entry lines up with the nav buttons and stays visible in the compact layout, where the footer was hidden. - Tests cover the read-only status, the locked keychain, opening from another Settings tab, and a cancelled discard of a profile edit. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
enaboapps
marked this pull request as ready for review
October 6, 2026 18:57
The sidebar account entry now opens an Account page, highlighted like the other sidebar destinations while it is open, and Settings no longer has an Account tab. The section is titled Switchify account and no longer repeats the page's subtitle. Refs #992 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #992
Part of #988.
What
data-active,aria-current="page") while the Account page is open, like the other sidebar destinations.nav-button, and it stays visible in the compact layout under 800 px, where the footer used to be hidden.get_account_statuscommand, so loading it never re-reads or prompts for the keychain. Opening the Account page still retries the keychain, and itsget_accountnow broadcastsaccount-changed, so a recovered sign-in reaches the sidebar.account-changed(sign-in, sign-out, delete, a session rejected elsewhere).Validation
npm run lint,npm test(287 passed) andnpm run build. The sidebar and Account page tests cover:cargo clippyis clean, andcargo test --libpasses (708).🤖 Generated with Claude Code