Repository navigation
Stop uploading the Windows signing runner npm cache - #980
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows releases spend most of their time saving the persistent signing runner’s global npm cache. In rc.20, the signed package built in 6 minutes, then compression and upload of the 6.7 GB cache took 42 minutes 40 seconds.
Remove the two setup-node npm cache inputs from the Windows release job. Node 24 and npm ci continue using the runner’s local cache without uploading it to GitHub.
Closes #979.
Validation
cd128404e960e3915c2658c74572cb344197b877found no actionable findings and confirmed the runner's local npm cache remains available.