Skip to content

Stop uploading the Windows signing runner npm cache - #980

Merged
enaboapps merged 1 commit into
mainfrom
codex/979-windows-release-npm-cache
Oct 5, 2026
Merged

enaboapps merged 1 commit into
mainfrom
codex/979-windows-release-npm-cache

Conversation

@enaboapps

@enaboapps enaboapps commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Windows releases spend most of their time saving the persistent signing runner’s global npm cache. In rc.20, the signed package built in 6 minutes, then compression and upload of the 6.7 GB cache took 42 minutes 40 seconds.

Remove the two setup-node npm cache inputs from the Windows release job. Node 24 and npm ci continue using the runner’s local cache without uploading it to GitHub.

Closes #979.

Validation

  • Release workflow YAML parses successfully; diff check passed.
  • The diff removes only the two cache inputs from the Windows signing job.
  • Node 24.19.0: prediction-model, lint, tests (253 UI and 12 script tests), and build passed.
  • Rust 1.97.1: fmt, clippy with warnings denied, and tests passed (634 unit tests, 2 ignored, 7 integration tests).
  • Actual release timing must be confirmed on the next release; no release was triggered for this change.
  • Independent review of head cd128404e960e3915c2658c74572cb344197b877 found no actionable findings and confirmed the runner's local npm cache remains available.
  • All required GitHub CI checks passed on the independently reviewed head, including frontend, dependency audit, CodeQL, and macOS/Windows native packaging and integration checks.

@enaboapps enaboapps added this to the v1.0.0-rc.21 milestone Oct 5, 2026
@enaboapps
enaboapps marked this pull request as ready for review October 5, 2026 08:51
@enaboapps
enaboapps merged commit 788f60b into main Oct 5, 2026
6 checks passed
@enaboapps
enaboapps deleted the codex/979-windows-release-npm-cache branch October 5, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stop uploading the signing runner npm cache on Windows releases

1 participant