Skip to content

Capitalise I and its contractions in suggestions - #917

Merged
enaboapps merged 2 commits into
mainfrom
909-i-contractions
Sep 26, 2026
Merged

enaboapps merged 2 commits into
mainfrom
909-i-contractions

Conversation

@enaboapps

@enaboapps enaboapps commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

Closes #909. Stacked on #916; part of the casing plan in #914.

What changed

  • In model.rs, display treats any key that is "i" or starts with "i'" as the pronoun and shows it with a capital I: "I'm", "I'll", "I've", "I'd". Keys are already normalised to a straight apostrophe, and the typed apostrophe style is still applied afterwards, so a typed "i’" gives "I’ll".
  • Applies to single words and to both words of a phrase.
  • A unit test covers "i", "i'm", "i'll" with a curly apostrophe, and that "is" is untouched. The bundled-model test adds "Tomorrow " + "i'", which yields I'm, I'll, I'd and I've, with phrases "I'm going" and "I'll be".
  • docs/word-prediction.md notes the rule.
  • A review noted the docs overstated the rule: typed letters keep their case, so the sentence now says the capital applies to the completed letters.

Validation

Node 24.13.0, Rust 1.97.1, on this top of the stack:

  • npm run lint, npm test (244 Vitest tests and 5 Node tests) and npm run build passed. No frontend files changed.
  • cargo fmt --check and cargo clippy --all-targets -D warnings passed.
  • cargo test passed: 567 tests.

🤖 Generated with Claude Code

@enaboapps enaboapps added this to the v1.0.0-rc.16 milestone Sep 25, 2026
@enaboapps
enaboapps force-pushed the 909-i-contractions branch 2 times, most recently from 9eb9a0c to 5e8a097 Compare September 25, 2026 19:18
@enaboapps
enaboapps marked this pull request as ready for review September 26, 2026 03:18
Base automatically changed from 908-proper-nouns to main September 26, 2026 08:37
OwenMcGirr and others added 2 commits September 26, 2026 09:37
"I" alone was already capital, but "i'm", "i'll", "i've" and "i'd"
still showed and inserted lowercase. Any key that is "i" or starts with
"i'" now gets a capital I, in single words and in both words of a
phrase, keeping the typed apostrophe style.

Closes #909

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@enaboapps
enaboapps merged commit bbb0f87 into main Sep 26, 2026
6 checks passed
@enaboapps
enaboapps deleted the 909-i-contractions branch September 26, 2026 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capitalise I and its contractions in suggestions

2 participants