Capitalise I and its contractions in suggestions - #917
Merged
Merged
Conversation
enaboapps
force-pushed
the
908-proper-nouns
branch
from
September 25, 2026 19:13
93b45f9 to
85ceee7
Compare
enaboapps
force-pushed
the
909-i-contractions
branch
2 times, most recently
from
September 25, 2026 19:18
9eb9a0c to
5e8a097
Compare
enaboapps
marked this pull request as ready for review
September 26, 2026 03:18
enaboapps
force-pushed
the
908-proper-nouns
branch
from
September 26, 2026 08:13
9ca53f9 to
b3e2dae
Compare
enaboapps
force-pushed
the
909-i-contractions
branch
from
September 26, 2026 08:13
44c3e45 to
57488ba
Compare
"I" alone was already capital, but "i'm", "i'll", "i've" and "i'd" still showed and inserted lowercase. Any key that is "i" or starts with "i'" now gets a capital I, in single words and in both words of a phrase, keeping the typed apostrophe style. Closes #909 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
enaboapps
force-pushed
the
909-i-contractions
branch
from
September 26, 2026 08:37
57488ba to
dab8433
Compare
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #909. Stacked on #916; part of the casing plan in #914.
What changed
model.rs,displaytreats any key that is "i" or starts with "i'" as the pronoun and shows it with a capital I: "I'm", "I'll", "I've", "I'd". Keys are already normalised to a straight apostrophe, and the typed apostrophe style is still applied afterwards, so a typed "i’" gives "I’ll".docs/word-prediction.mdnotes the rule.Validation
Node 24.13.0, Rust 1.97.1, on this top of the stack:
npm run lint,npm test(244 Vitest tests and 5 Node tests) andnpm run buildpassed. No frontend files changed.cargo fmt --checkandcargo clippy --all-targets -D warningspassed.cargo testpassed: 567 tests.🤖 Generated with Claude Code