Repository navigation
Share one dialog shell across main-window dialogs - #899
Merged
Merged
Conversation
enaboapps
force-pushed
the
888-mobile-layout
branch
from
September 25, 2026 10:56
33199c1 to
a78e898
Compare
enaboapps
force-pushed
the
889-dialog-shell
branch
from
September 25, 2026 10:56
6534a07 to
7f8c097
Compare
enaboapps
force-pushed
the
888-mobile-layout
branch
from
September 25, 2026 11:03
a78e898 to
60a4698
Compare
enaboapps
force-pushed
the
889-dialog-shell
branch
from
September 25, 2026 11:03
7f8c097 to
8c8ca01
Compare
Setup, pairing, profile, confirmation, practice and capture dialogs now share one surface, radius, padding and shadow, with matching header and footer spacing. The setup guide sizes to its step up to the window instead of a fixed 900px, with a sentence-case label and a thicker step rail. Pairing requests are cards with the code set large for comparison. Opening a dialog is a short fade and rise that reduced motion skips, and dialogs show a focus ring only for keyboard focus. Closes #889 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
A device name without spaces ran under the verification code; it now wraps within its column. A note on the entrance animation records why it must never leave a transform on the setup guide. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
enaboapps
marked this pull request as ready for review
September 25, 2026 11:49
enaboapps
force-pushed
the
888-mobile-layout
branch
from
September 25, 2026 11:50
60a4698 to
d8f1d35
Compare
enaboapps
force-pushed
the
889-dialog-shell
branch
from
September 25, 2026 11:50
8c8ca01 to
919c498
Compare
enaboapps
marked this pull request as draft
September 25, 2026 11:50
enaboapps
marked this pull request as ready for review
September 25, 2026 15:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #889. Stacked on #898, tracked in #891.
What changed
prefers-reduced-motionturns this off, along with the capture pulse and button transitions.Validation
On this head:
npm run lintpassednpm testpassed: 238 Vitest tests and 5 Node testsnpm run buildpassedcargo fmt --check,cargo clippy --all-targets -D warningsandcargo testpassed (566 tests, 1 ignored). No Rust changes in this stack.Review follow-up
An independent review of this layer's head raised these points, now addressed:
🤖 Generated with Claude Code
Rebase validation (2026-09-25)
Rebased onto current
main(7fb8fce, including #881) in stack order.git range-diffshows every commit in this PR is patch-equivalent to its previous head, and the intended parent remains its PR base. On the final stack tip (40c75cc), Node 24.19.0 lint, tests and build passed; Rust 1.97.1 format check, Clippy and tests passed. An independent review of the updated PR heads found no actionable findings. CI is rerunning on each new head.