Repository navigation
Share one scan panel layout between keyboard and mouse - #861
Merged
Merged
Conversation
Extract the keyboard's panel geometry into scan_panel so panels only describe their rows and status. The keyboard renders through it with unchanged output; the Mouse panel gains the keyboard's size, padding, gaps, status tile and paused/back-to-rows/select prompts. Closes #860. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #860.
The keyboard's panel layout now lives in a new
scan_panelmodule: panel size, padding, weighted rows with even gaps, the status tile and docking. The keyboard and the Mouse panel only supply their keys and status text.Validation:
npm run lint,npm test(218 UI tests, 5 Node tests) andnpm run buildpass.cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testpass (517 unit tests, 1 ignored, 7 integration tests). New tests cover the shared layout (padding, gaps, weights, status tile, docking, highlighting) and the Mouse panel (keyboard geometry, status wording, moving and failed states).4f47d65found no blocking issues and two minor ones. Both are fixed infe46f8a: the speed keys now use two-line labels ("Slower / 100%"), so the status reads "More controls · Select Slower 100%" instead of having two separators, and a workflow test now checks the moving prompt with nothing highlighted. Independent review of latest headfe46f8afound no actionable findings. Rust checks re-run onfe46f8a: fmt, clippy and 517 unit tests pass.fe46f8a: frontend, dependency audit, macOS native, Windows native/NSIS, CodeQL, and JavaScript/TypeScript analysis.🤖 Generated with Claude Code