Repository navigation
Present Point and Mouse as scanning modes - #859
Merged
Merged
Conversation
enaboapps
marked this pull request as ready for review
September 23, 2026 14:04
Settings saves from the UI keep the runtime-owned control mode instead of overwriting it with a stale value. All scanning settings writes now replace the file atomically, and a failed mode save no longer cancels the switch action. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #858.
Present Point and Mouse as the two primary scanning modes. Select resumes the last explicitly used mode across app restarts, defaulting to Point for older settings. Add Open Point as an additive switch action; the Mouse panel now switches directly to Point. The Scanning page explains both paths before shared and advanced settings.
Validation:
npm run lint,npm test, andnpm run buildpassed (218 UI tests and 5 Node tests).cargo fmt --manifest-path src-tauri/Cargo.toml --check,cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warnings, andcargo test --manifest-path src-tauri/Cargo.tomlpassed (512 unit tests, 1 ignored, 7 integration tests).4cea753with Node 24.19.0 and Rust 1.97.1 usingnpm run tauri -- build --debug --no-bundle --target aarch64-pc-windows-msvc. Tested native switch key press/release edges against ordinary Notepad windows: Select started Point, Open Mouse entered Mouse, Open Point returned to Point, and the Mouse panel's Switch to Point tile returned to Point. Escape stopped without changing the saved Mouse mode; after app restart, Select reopened Mouse. The pointer ring appeared in Mouse and cleared on Point/Stop. The native settings page displayed the two mode cards and the saved Select mode. Restored original VM configuration files byte-for-byte and left the corrected build running.4cea753found no actionable findings.4cea753: frontend (rerun after an unrelated switch-practice focus timing failure), dependency audit, macOS native, Windows native/NSIS and UI Access, CodeQL, and JavaScript/TypeScript analysis.Follow-up review fixes (
ddbd3ad,d14d0e1):cargo fmt --check,cargo clippy --all-targets -- -D warningsandcargo testpass (514 unit tests, 1 ignored, 7 integration tests). Node 24:npm run lintandnpm testpass (218 UI tests, 5 Node tests). The frontend is unchanged, so the build was not re-run. The Windows VM test has not been repeated on these commits.d14d0e1found no actionable findings. Two points were accepted as-is: the mode is saved before its action runs, and the runtime paths that need anAppHandlehave no tests.🤖 Generated with Claude Code