Repository navigation
Add contextual setup demonstrations - #849
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup and contextual help now offer optional illustrated demonstrations for connecting and learning switches, assigning Select, scanning, press/hold/release, macOS Accessibility, mobile pairing and startup behavior. Adapted local SVG prototype artwork uses a shared React player: play once on opening, pause/replay, manually stepped reduced-motion illustrations, and cleanup when hidden or unmounted.
Demonstrations are labelled as examples and never operate hardware or change settings. Scanning follows row/cell/line selection, distinguishes Auto select from the action menu, and includes a line-only example. Hold teaching finishes with release executing the offered action; pairing uses six-digit example codes and explains rejecting mismatches. Existing setup flow, native runtime, protocol and storage are unchanged.
Closes #848.
Validation: Node 24/Rust 1.97.1; frontend lint, 211 UI tests plus 5 update-feed tests, and production build passed. Cargo formatting, clippy and all 506 Rust tests passed. Windows 11 ARM64 native build and visual checks passed for contextual help, play-on-open, completion, pause/replay, setup navigation and dark-mode contrast; the original VM theme was restored. Reduced motion, lifecycle cleanup and capture/pairing suspension are covered by automated tests. Independent review of latest head
d7577f2cda21e06eb55b628335a04f4687826a69found no remaining actionable issues. All CI checks passed, including macOS app/DMG, Windows NSIS, frontend, dependency audit and CodeQL. The frontend passed on retry after its first attempt hit the unchanged switch-practice focus-restoration test; that test also passed locally. The local installation is untouched.