Repository navigation
Use Mobile terminology for companion connections - #847
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generic companion-device connections now use Mobile terminology throughout navigation, pairing, settings, accessibility text, native messages and application metadata. Matching React components, props, view/tab IDs, CSS classes, the QR asset filename and Rust typing-route names use mobile consistently.
Android-specific protocol compatibility names, fixture values, platform provenance and repository URLs remain intact. The Google Play destination and QR image bytes are unchanged; wire interfaces and persisted schemas are unchanged.
Closes #846.
Validation: Node 24.19.0 and Rust 1.97.1;
npm run lint,npm test(194 UI + 5 feed tests),npm run build,cargo fmt --manifest-path src-tauri/Cargo.toml --check,cargo clippy --manifest-path src-tauri/Cargo.toml --all-targets -- -D warnings, andcargo test --manifest-path src-tauri/Cargo.tomlpassed. Windows 11 ARM64 VM: full Rust tests and native Tauri build passed; manually verified Home, Mobile connection, QR rendering, Paired devices, Switch Forwarding and Switches status copy. Bluetooth was unavailable in the VM, so no physical pairing test was performed. Independent review of head31616ba808ccd15f1ceb4f28c7835a0bc952adc7found no actionable issues. All CI checks passed, including macOS app/DMG and Windows NSIS builds, frontend, dependency audit and CodeQL. The local installed app was not modified or launched for validation.