Repository navigation
Protect switch removal and new drafts from accidental loss - #831
Merged
Merged
Conversation
enaboapps
force-pushed
the
codex/switch-loss-protection-827
branch
from
September 21, 2026 14:35
ce26289 to
9976209
Compare
enaboapps
marked this pull request as ready for review
September 21, 2026 15:04
Keep switch removal confirmation with remote-preset source labels from main. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch deletion and populated new-draft cancellation now require an accessible confirmation. Failed saves retain the assignment and keep recovery available; untouched drafts still cancel immediately. Focus returns to the appropriate control after the dialog closes and the background becomes interactive.
This PR is stacked on #832 and preserves keyboard-entry cleanup after confirmed deletion.
Validation: lint/build, 180 frontend tests plus 5 feed tests passed. Rust formatting/Clippy, 510 Rust unit tests and 7 integration tests passed before the final frontend-only focus changes; one existing test ignored. Independent review passed at e17de72. Regression tests and a real browser check verify focus after deletion and draft discard, including inert background cleanup. Native Windows ARM64 checks passed for Keep/Discard draft, local and remote deletion, focus restoration and keyboard-entry cleanup on the combined build.
Closes #827.