Skip to content

Add optional wait after keyboard typing - #808

Merged
enaboapps merged 1 commit into
mainfrom
codex/keyboard-wait-807
Sep 20, 2026
Merged

enaboapps merged 1 commit into
mainfrom
codex/keyboard-wait-807

Conversation

@enaboapps

@enaboapps enaboapps commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

Add Scanning → Keyboard → After typing, with Continue scanning (existing default) and Wait for Select. Automatic keyboard users can now type one key or suggestion and rest until their next Select press. That press resumes a full scan interval without typing again.

The persisted keyboardWaitAfterTyping flag defaults false for existing configurations. It is retained but disabled in manual mode. Modifiers, row selection, layouts and controls remain immediate. The wait uses the existing suspended keyboard state with a specific HUD message and survives prediction refreshes and pause/resume. No BLE changes.

Validation:

  • Frontend lint, 159 tests, 5 script tests and production build pass.
  • Rust format, Clippy, 482 unit tests and 7 configuration tests pass; one existing ignored benchmark.
  • Regression tests cover defaults/roundtrip, UI persistence/manual mode, both patterns/directions, full resume interval, duplicate completion, predictions, editing/navigation keys, controls, errors, pause/hold, stop and configuration reset.
  • Independent latest-head review of ecbc4cb: no actionable findings.
  • Mac and Windows ARM VMs: opened Keyboard through More without moving text focus, typed one character exactly once, observed the waiting HUD and stationary highlight, then resumed with Select without inserting another character.
  • Native suggestion acceptance was not exercised because the test builds had no usable suggestions; automated tests cover that path.
  • Restored both VMs’ settings byte-for-byte, restarted the previous Windows build and returned the Mac VM to suspended. The signed local Mac app remained untouched.
  • CI: frontend, dependency audit, CodeQL, macOS native checks/package and Windows native checks/UIAccess package all passed (run 35522874340).

Closes #807. No merge or release requested.

Preserve automatic scanning by default and allow Select-only resumption after successful typing. Persist the keyboard-specific preference and cover timing, predictions, pause, cleanup and configuration compatibility.
@enaboapps
enaboapps marked this pull request as ready for review September 20, 2026 16:37
@enaboapps
enaboapps merged commit 5ca7c88 into main Sep 20, 2026
6 checks passed
@enaboapps
enaboapps deleted the codex/keyboard-wait-807 branch September 22, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add optional wait after keyboard typing

1 participant